Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove usage of AllocatedBuffer from crypto_common.cc #40213

Conversation

RaisinTen
Copy link
Contributor

Signed-off-by: Darshan Sen darshan.sen@postman.com

Signed-off-by: Darshan Sen <darshan.sen@postman.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Sep 25, 2021
@nodejs-github-bot

This comment has been minimized.

@RaisinTen RaisinTen removed the needs-ci PRs that need a full CI run. label Sep 25, 2021
@nodejs-github-bot
Copy link
Collaborator

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 25, 2021
XadillaX pushed a commit that referenced this pull request Sep 28, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #40213
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
@XadillaX
Copy link
Contributor

XadillaX commented Sep 28, 2021

Landed in 2caa308

@XadillaX XadillaX closed this Sep 28, 2021
@RaisinTen RaisinTen deleted the src/remove-usage-of-AllocatedBuffer-from-crypto_common.cc branch September 28, 2021 12:21
targos pushed a commit that referenced this pull request Oct 4, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #40213
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants