Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: add .mailmap entry for Jimbly #40267

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 30, 2021

Consolidate two email addresses for Jimbly into one AUTHORS record using
.mailmap.

Consolidate two email addresses for Jimbly into one AUTHORS record using
.mailmap.
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 30, 2021
@Trott
Copy link
Member Author

Trott commented Sep 30, 2021

@Jimbly I have to imagine both "Jimb Esser" entries are you, but nonetheless, if you could confirm that they aren't two different Jimb Essers, that would be great.

@Trott
Copy link
Member Author

Trott commented Sep 30, 2021

@Jimbly I have to imagine both "Jimb Esser" entries are you, but nonetheless, if you could confirm that they aren't two different Jimb Essers, that would be great.

Also, confirming that we're keeping the right email address here would also be great!

@Jimbly
Copy link
Contributor

Jimbly commented Sep 30, 2021

Yup, those are both me, and that's the appropriate address.

@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 30, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Oct 3, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2021

Landed in 8a58fce...b5cfb26

@github-actions github-actions bot closed this Oct 3, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 3, 2021
Consolidate two email addresses for Jimbly into one AUTHORS record using
.mailmap.

PR-URL: #40267
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Oct 4, 2021
Consolidate two email addresses for Jimbly into one AUTHORS record using
.mailmap.

PR-URL: #40267
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott Trott deleted the mailmap-je branch September 25, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants