Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: V8: make V8 9.5 ABI-compatible with 9.6 #40422

Closed
wants to merge 1 commit into from
Closed

deps: V8: make V8 9.5 ABI-compatible with 9.6 #40422

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Oct 12, 2021 •
edited
Loading

Cherry-pick ABI-breaking changes that happened since 9.5 was branched:

[api] Remove deprecated HostImportModuleDynamicallyCallback
Refs: v8/v8@ab83685

[zone] Provide a way to configure allocator for zone backings
Refs: v8/v8@e262e1c

[isolate-data] Consistent field names
Needed for the next commit.
Refs: v8/v8@d09fc54

[isolate-data] Split builtin tables into tiers
Refs: v8/v8@06af754

[mips][loong64][isolate-data] Split builtin tables into tiers
Refs: v8/v8@1fd5561

[riscv64] Replace builtin_entry_slot_offset with BuiltinEntrySlotOffset
Refs: v8/v8@b66d5f0

ppc/s390: [isolate-data] Split builtin tables into tiers
Refs: v8/v8@dc88bdf

@targos targos requested review from MylesBorins and removed request for MylesBorins October 12, 2021 06:53
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Oct 12, 2021
This was referenced Oct 12, 2021
Closed
Merged
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 12, 2021 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/40255/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4321/

@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 12, 2021
@Mesteery Mesteery removed the needs-ci PRs that need a full CI run. label Oct 12, 2021
@github-actions github-actions bot mentioned this pull request Oct 13, 2021
Open
22 tasks
@targos
Copy link
Member Author

targos commented Oct 13, 2021 

20:24:34 ../../src/codegen/ppc/macro-assembler-ppc.cc:3642:39: error: ‘builtin_entry_slot_offset’ is not a member of ‘v8::internal::IsolateData’
20:24:34                           IsolateData::builtin_entry_slot_offset(target)));
20:24:34                                        ^~~~~~~~~~~~~~~~~~~~~~~~~

Looks like I need to cherry-pick platform-specific changes. I'll do that later today.

@targos
deps: V8: make V8 9.5 ABI-compatible with 9.6
60622aa 
Cherry-pick ABI-breaking changes that happened since 9.5 was branched:

[api] Remove deprecated HostImportModuleDynamicallyCallback
Refs: v8/v8@ab83685

[zone] Provide a way to configure allocator for zone backings
Refs: v8/v8@e262e1c

[isolate-data] Consistent field names
Needed for the next commit.
Refs: v8/v8@d09fc54

[isolate-data] Split builtin tables into tiers
Refs: v8/v8@06af754

[mips][loong64][isolate-data] Split builtin tables into tiers
Refs: v8/v8@1fd5561

[riscv64] Replace builtin_entry_slot_offset with BuiltinEntrySlotOffset
Refs: v8/v8@b66d5f0

ppc/s390: [isolate-data] Split builtin tables into tiers
Refs: v8/v8@dc88bdf
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 13, 2021 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/40278/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4324/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40288/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40293/

@github-actions github-actions bot mentioned this pull request Oct 14, 2021
Open
22 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40295/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40297/

@targos
Copy link
Member Author

targos commented Oct 14, 2021

Landed in 795108a

@targos targos closed this Oct 14, 2021
@targos targos deleted the v8-95-96 branch October 14, 2021 06:43
targos added a commit that referenced this pull request Oct 14, 2021
@targos
deps: V8: make V8 9.5 ABI-compatible with 9.6
795108a 
Cherry-pick ABI-breaking changes that happened since 9.5 was branched:

[api] Remove deprecated HostImportModuleDynamicallyCallback
Refs: v8/v8@ab83685

[zone] Provide a way to configure allocator for zone backings
Refs: v8/v8@e262e1c

[isolate-data] Consistent field names
Needed for the next commit.
Refs: v8/v8@d09fc54

[isolate-data] Split builtin tables into tiers
Refs: v8/v8@06af754

[mips][loong64][isolate-data] Split builtin tables into tiers
Refs: v8/v8@1fd5561

[riscv64] Replace builtin_entry_slot_offset with BuiltinEntrySlotOffset
Refs: v8/v8@b66d5f0

ppc/s390: [isolate-data] Split builtin tables into tiers
Refs: v8/v8@dc88bdf

PR-URL: #40422
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
@github-actions github-actions bot mentioned this pull request Oct 15, 2021
Open
23 tasks
This was referenced Oct 16, 2021
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@targos @nodejs-github-bot @BethGriggs @aduh95 @Mesteery