configure: respect CC_host in host arch detection #4117
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaocgreis
added
build
| @@ -583,7 +583,7 @@ def host_arch_cc(): | |||
| # would be xlc so hard code gcc | |||
| k = cc_macros('gcc') | |||
| else: | |||
| k = cc_macros() | |||
| k = cc_macros(os.environ.get('CC_host', None)) | |||
There was a problem hiding this comment.
You can drop the second argument, None is the default value when the key is not found. LGTM apart from that.
|
LGTM |
joaocgreis
force-pushed
the
joaocgreis-FC2-CC_host
branch
from
57032ff
to
2b52ba4
Compare
|
Updated, thanks for the reviews! Will land Tuesday if there are no further comments. |
When cross compiling, GYP uses the variables CC_host and CXX_host to find the host compiler, if they are defined. This ensures that variable is used, if defined, when detecting the host architecture. Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: nodejs#4117
joaocgreis
force-pushed
the
joaocgreis-FC2-CC_host
branch
from
2b52ba4
to
0e3912b
Compare
joaocgreis
added a commit
that referenced
this pull request
Dec 9, 2015
When cross compiling, GYP uses the variables CC_host and CXX_host to find the host compiler, if they are defined. This ensures that variable is used, if defined, when detecting the host architecture. Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #4117
|
Landed in |
joaocgreis
added a commit
that referenced
this pull request
Dec 15, 2015
When cross compiling, GYP uses the variables CC_host and CXX_host to find the host compiler, if they are defined. This ensures that variable is used, if defined, when detecting the host architecture. Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #4117
Closed
joaocgreis
added a commit
that referenced
this pull request
Dec 17, 2015
When cross compiling, GYP uses the variables CC_host and CXX_host to find the host compiler, if they are defined. This ensures that variable is used, if defined, when detecting the host architecture. Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #4117
joaocgreis
added a commit
that referenced
this pull request
Dec 23, 2015
When cross compiling, GYP uses the variables CC_host and CXX_host to find the host compiler, if they are defined. This ensures that variable is used, if defined, when detecting the host architecture. Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #4117
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
When cross compiling, GYP uses the variables CC_host and CXX_host to find the host compiler, if they are defined. This ensures that variable is used, if defined, when detecting the host architecture. Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: nodejs#4117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cross compiling, GYP uses the variables CC_host and CXX_host to find the host compiler, if they are defined. This ensures that variable is used, if defined, when detecting the host architecture.
This is necessary to be able to cross compile for ARM, unblocking #3962 and nodejs/build#266 . Snapshots can be re-enabled for ARM on CI when this lands.
cc @nodejs/build