Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update AUTHORS list #4183

Closed
wants to merge 1 commit into from
Closed

doc: update AUTHORS list #4183

wants to merge 1 commit into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Dec 8, 2015

Update AUTHORS list using tools/update-authors.sh

This is a big 'un! We need some input from some individuals this pulls in wrt their details:

  • @john-yan you have two email addresses in your commits, I've consolidated under your ca.ibm.com address, is that OK?
  • @MJefferson you are listed as just "Martial", most of us have full names in here but that's not mandatory, what would you prefer?
  • @calebboyd, @fansworld-claudio, @Martii and @Zirak you are listed as "calebboyd", "fansworld-claudio", "Martii" and "Zirak" respectively, most of us have actual names in here but that's not mandatory, can you tell us how you should be listed?
  • @phijohns you are using two email addresses in your commits, I've consolidated under your gmail.com, is that OK?
  • @hellopao you are listed as "qinjia", most of us have actual names in here but that's not mandatory, can you tell us how you should be listed?
  • @evanlucas your name comes under 3 separate email addresses now, see .mailmap, can you tell me (a) are all 3 you? and (b) which one should be listed?
  • @JonathanP you are listed as "jpersson", most of us have actual names in here but that's not mandatory, can you tell us how you should be listed?
  • @Henninger you are listed as just "Dave", most of us have full names in here but that's not mandatory, what would you prefer?
  • @SPGB you are listed with a noreply GitHub email address, most of us have a real address but it's not mandatory, can you tell us what you'd prefer here?
  • @baslr you are listed as "Manuel B", most of us have full names but it's not mandatory, can you let us know what you'd prefer? You are also listed with a noreply GitHub email address, most of us have a real address but it's not mandatory, can you tell us what you'd prefer here?

@evanlucas
Copy link
Contributor

@rvagg All 3 are me. I prefer evanlucas@me.com. Sorry for the confusion on that

@hellopao
Copy link
Contributor

hellopao commented Dec 8, 2015

@rvagg you can list me as "Jerry Chin", tks!

@rvagg
Copy link
Member Author

rvagg commented Dec 8, 2015

@jkrems you are listed with two different email addresses, see .mailmap in this PR, I've consolidated you under your gmail, which would you prefer?

@evanlucas no problems at all, that's what .mailmap is for.

@hellopao done, thanks!

@jkrems
Copy link
Contributor

jkrems commented Dec 8, 2015

@rvagg Gmail is the preferred one. Guess I messed up my git config for that other commit.

@calebboyd
Copy link
Contributor

@rvagg, You can list me as "Caleb Boyd". Thanks!

@mscdex mscdex added the doc Issues and PRs related to the documentations. label Dec 8, 2015
@svenheden
Copy link

You can list me as Jonathan Persson and with my gmail persson.jonathan@gmail.com, thanks!

@Martii
Copy link

Martii commented Dec 8, 2015

can you tell us how you should be listed?

Marti Martz
Same email is fine as it's specific to development and not exactly private. Rambling on note: The reason my GH username isn't Marti is because someone took that way back in the early days of GH. sniff Ah well... if needed reference Martii in there somewhere if you like.

Appreciate the acknowledgement for my tiny little contribution. :)

P.S. Thanks to your team for all they do.

@rvagg
Copy link
Member Author

rvagg commented Dec 8, 2015

@jkrems done
@JonathanP done on both counts
@Martii updated, we appreciate even the smallest contributions, welcome on board!

@rvagg
Copy link
Member Author

rvagg commented Dec 8, 2015

@calebboyd done

@john-yan
Copy link

john-yan commented Dec 8, 2015

Hello @rvagg , could you plz put both of my emails, john.yan1019@gmail.com and jyan@ca.ibm.com? since I couldn't be able to check email while I am not able to connect to the IBM internal network. Thanks!

@rvagg
Copy link
Member Author

rvagg commented Dec 8, 2015

thanks @john-yan, I've updated .mailmap to use your gmail.com address, see attached commit.

@claudiorodriguez
Copy link
Contributor

That's strange, my github profile has my real name which is Claudio Rodriguez, is that not showing for you? Mail is cjrodr at yahoo dot com

@rvagg
Copy link
Member Author

rvagg commented Dec 8, 2015

Thanks @fansworld-claudio, updated. This all comes from git itself, see https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit on how to set up your details in your local .gitconfig which is what determines what goes into your commit log.

@MJefferson
Copy link
Contributor

Appreciate the love Rod. Please list me as Martial James Jefferson.

Best,

Thanks

On Tue, Dec 8, 2015 at 12:56 AM, Rod Vagg notifications@github.com wrote:

Thanks @fansworld-claudio https://github.com/fansworld-claudio,
updated. This all comes from git itself, see
https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit
on how to set up your details in your local .gitconfig which is what
determines what goes into your commit log.


Reply to this email directly or view it on GitHub
#4183 (comment).

@SPGB
Copy link
Contributor

SPGB commented Dec 8, 2015

Hi @rvagg, my preference is samgallagherb@gmail.com.

Thanks

@Zirak
Copy link
Contributor

Zirak commented Dec 8, 2015

Hurray, virtual fame for life!

@rvagg Zirak and zirakertan@gmail.com (what you currently have) are more than fine. Thanks for the consideration.

@dbkaplun
Copy link
Contributor

dbkaplun commented Dec 9, 2015

Hi @rvagg, can you update my email address to dbkaplun@gmail.com please? (Dan Kaplun)

@rvagg
Copy link
Member Author

rvagg commented Dec 10, 2015

@dbkaplun done, see .mailmap

@wurde you're now in this list, could you please let us know what we can put for your real name? Most of us have our full names but it's not mandatory, your git settings make you simply wurde.

@rvagg rvagg force-pushed the update-authors branch 2 times, most recently from 9c76a40 to b2863f9 Compare December 10, 2015 00:33
@rvagg
Copy link
Member Author

rvagg commented Dec 10, 2015

@hemanth you are listed here as "Hemanth.HM" due to your git settings. Most of us have a full name listed, would you like to have yours adjusted or are you happy with how it is?

@dbkaplun
Copy link
Contributor

@rvagg thanks! (BTW I don't have the other email address anymore so the line in .mailmap is not needed)

@rvagg
Copy link
Member Author

rvagg commented Dec 10, 2015

Friendly reminder to @pflannery, @bcbcb, @wizicer, @jimmyhsu, @stcruy, @DannyNemer @baslr who may have been asked before: your entry in AUTHORS is listed with a GitHub noreply address. Most of us have a real email address listed and it is helpful to the project, if for example in the future we need to adjust licensing terms, however it's by no means mandatory if you'd prefer to not list an address. If you would like it changed, please let me know and I can update your entry.

@ghost
Copy link

ghost commented Dec 10, 2015

@wurde is Andy Bettisworth, hi! andy.bettisworth@accreu.com

@hemanth
Copy link
Contributor

hemanth commented Dec 10, 2015

@rvagg Thank for asking, I am happy with Hemanth.HM <hemanth.hm@gmail.com> as my full name will consume 32chars ;)

@wizicer
Copy link
Contributor

wizicer commented Dec 10, 2015

Thanks @rvagg for the reminder, I'd like to use Icer Liang <liangshuangde@163.com>

@baslr
Copy link
Contributor

baslr commented Dec 10, 2015

@rvagg diff is fine.

@jasnell
Copy link
Member

jasnell commented Dec 11, 2015

Once all the author metadata is updated, this LGTM

Awesome to see so many names being added!

Update AUTHORS list using tools/update-authors.sh
@jasnell
Copy link
Member

jasnell commented Dec 14, 2015

@rvagg ... is this about ready?

rvagg added a commit that referenced this pull request Dec 15, 2015
Update AUTHORS list using tools/update-authors.sh

PR-URL: #4183
Reviewed-By: James M Snell <jasnell@gmail.com>
@rvagg
Copy link
Member Author

rvagg commented Dec 15, 2015

done, 59 new authors since last time I did this 2 months ago @ 0116da1!

@rvagg rvagg closed this Dec 15, 2015
@rvagg
Copy link
Member Author

rvagg commented Dec 15, 2015

435d571

@rvagg rvagg deleted the update-authors branch December 15, 2015 06:14
@hemanth
Copy link
Contributor

hemanth commented Dec 15, 2015

👍

@jasnell
Copy link
Member

jasnell commented Dec 15, 2015

That's fantastic! Thanks @rvagg!
On Dec 14, 2015 10:14 PM, "Rod Vagg" notifications@github.com wrote:

done, 59 new authors since last time I did this 2 months ago @ 0116da1
0116da1
!


Reply to this email directly or view it on GitHub
#4183 (comment).

rvagg added a commit that referenced this pull request Dec 15, 2015
Update AUTHORS list using tools/update-authors.sh

PR-URL: #4183
Reviewed-By: James M Snell <jasnell@gmail.com>
@rvagg rvagg mentioned this pull request Dec 17, 2015
rvagg added a commit that referenced this pull request Dec 29, 2015
Update AUTHORS list using tools/update-authors.sh

PR-URL: #4183
Reviewed-By: James M Snell <jasnell@gmail.com>
@jimmyhsu
Copy link
Contributor

jimmyhsu commented Jan 6, 2016

@rvagg Apologies for being so late. I've been busy and didn't notice this until now. Might be too late, but my email for contact is jimmyhsu+github@live.com. If there's another ticket open for this let me know and I can post it there as I didn't realize it was a github noreply email prior to this.

MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
Update AUTHORS list using tools/update-authors.sh

PR-URL: #4183
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Update AUTHORS list using tools/update-authors.sh

PR-URL: nodejs#4183
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.