Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update libuv to 1.2.1 #423

Closed
wants to merge 1 commit into from
Closed

deps: update libuv to 1.2.1 #423

wants to merge 1 commit into from

Conversation

saghul
Copy link
Member

@saghul saghul commented Jan 14, 2015

R=@piscisaureus, @bnoordhuis

I got the following test failure, looks unrelated:

$ make test-simple 
ninja -v -C out/Release/
ninja: Entering directory `out/Release/'
ninja: no work to do.
ln -fs out/Release/iojs iojs
/usr/bin/python tools/test.py parallel sequential
=== release test-debug-signal-cluster ===                                      
Path: parallel/test-debug-signal-cluster
> all workers are running
> Starting debugger agent.
> Debugger listening on port 12388
> Starting debugger agent.
> Debugger listening on port 12390
got pids [25485,25491,25497]

assert.js:100
  throw new assert.AssertionError({
        ^
AssertionError: 4 == 6
    at assertOutputLines (/home/saghul/src/io.js/test/parallel/test-debug-signal-cluster.js:80:10)
    at onNoMoreLines [as _onTimeout] (/home/saghul/src/io.js/test/parallel/test-debug-signal-cluster.js:48:3)
    at Timer.listOnTimeout (timers.js:90:15)
Command: out/Release/iojs /home/saghul/src/io.js/test/parallel/test-debug-signal-cluster.js
[02:45|% 100|+ 771|-   1]: Done                                                
Makefile:144: recipe for target 'test-simple' failed
make: *** [test-simple] Error 1

piscisaureus pushed a commit to piscisaureus/node2 that referenced this pull request Jan 14, 2015
PR: nodejs#423
Reviewed-by: Bert Belder <bertbelder@gmail.com>
@bnoordhuis
Copy link
Member

parallel/test-debug-signal-cluster is a timing sensitive test, it's being tracked in #340. Waiting for the CI to finish: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/76/

@piscisaureus
Copy link
Contributor

@piscisaureus
Copy link
Contributor

lol, race condition

piscisaureus pushed a commit that referenced this pull request Jan 14, 2015
PR: #423
Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-by: Bert Belder <bertbelder@gmail.com>
@piscisaureus
Copy link
Contributor

Thanks @saghul, landed in 07bd05b.

@saghul saghul deleted the uv-121 branch January 14, 2015 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants