Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v12.22.12 proposal #42531

Merged
merged 15 commits into from
Apr 5, 2022
Merged

v12.22.12 proposal #42531

merged 15 commits into from
Apr 5, 2022

Commits on Mar 17, 2022

  1. doc: add release key for Bryan English

    Adds Bryan English and his public key to the README for releases.
    
    PR-URL: #42102
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
    bengl authored and richardlau committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    a35f553 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2022

  1. deps: V8: cherry-pick cc9a8a37445e

    Original commit message:
    
        fix overflow check in error formatting
    
        Bug: v8:12494
        Change-Id: Iba2684173296aa236f1a1c73a5606c21472eff06
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3426634
        Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
        Commit-Queue: Gus Caplan <snek@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#78909}
    
    Refs: v8/v8@cc9a8a3
    
    PR-URL: #42065
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    devsnek committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    1193290 View commit details
    Browse the repository at this point in the history
  2. node-api: force env shutdown deferring behavior

    The finalizer normally never gets called while a reference is strong.
    However, during environment shutdown all finalizers must get called. In
    order to unify the deferring behavior with that of a regular
    finalization, we must force the reference to be weak when we call its
    finalizer during environment shutdown.
    
    Fixes: #37236
    Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
    PR-URL: #37303
    Backport-PR-URL: #42512
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    2 people authored and richardlau committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    171bb66 View commit details
    Browse the repository at this point in the history
  3. node-api: stop ref gc during environment teardown

    A gc may happen during environment teardown. Thus, during finalization
    initiated by environment teardown we must remove the V8 finalizer
    before calling the Node-API finalizer.
    
    Fixes: #37236
    PR-URL: #37616
    Backport-PR-URL: #42512
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    gabrielschulhof authored and richardlau committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    a2f4206 View commit details
    Browse the repository at this point in the history
  4. node-api: fix crash in finalization

    Refs: nodejs/node-addon-api#906
    Refs: #37616
    
    Fix crash introduced by #37616
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #37876
    Backport-PR-URL: #42512
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mhdawson authored and richardlau committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    2aa9ca1 View commit details
    Browse the repository at this point in the history
  5. node-api: make reference weak parameter an indirect link to references

    As the cancellation of second pass callbacks are not reachable from the
    current v8 API, and the second pass callbacks are scheduled with
    NodePlatform's task runner, we have to ensure that the weak parameter
    holds indirect access to the v8impl::Reference object so that the object
    can be destroyed on addon env teardown before the whole node env is able
    to shutdown.
    
    PR-URL: #38000
    Backport-PR-URL: #42512
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
    legendecas authored and richardlau committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    81b4dc8 View commit details
    Browse the repository at this point in the history
  6. src: fix finalization crash

    PR-URL: #38250
    Backport-PR-URL: #42512
    Fixes: #38040
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    jasnell authored and richardlau committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    e707514 View commit details
    Browse the repository at this point in the history
  7. node-api: fix shutdown crashes

    Refs: nodejs/node-addon-api#906
    
    Ensure that finalization is not defered during shutdown.
    The env for the addon is deleted immediately after
    iterating the list of finalizers to be run. Defering
    causes crashes as the finalization uses the already
    deleted env.
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #38492
    Backport-PR-URL: #42512
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
    mhdawson authored and richardlau committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    a7224c9 View commit details
    Browse the repository at this point in the history
  8. node-api: avoid SecondPassCallback crash

    PR #38000 added
    indirection so that we could stop finalization in
    cases where it had been scheduled in a second
    pass callback but we were doing it in advance in
    environment teardown.
    
    Unforunately we missed that the code which tries
    to clear the second pass parameter checked if
    the pointer to the parameter (_secondPassParameter)
    was nullptr and that when the second pass callback
    was scheduled we set _secondPassParameter to nullptr
    in order to avoid it being deleted outside of the second
    pass callback. The net result was that we
    would not clear the _secondPassParameter contents
    and failed to avoid the Finalization in the second pass
    callback.
    
    This PR adds an additional boolean for deciding if
    the secondPassParameter should be deleted outside
    of the second pass callback instead of setting
    secondPassParameter to nullptr thus avoiding the
    conflict between the 2 ways it was being used.
    
    See the discussion starting at:
    #38273 (comment)
    for how this was discovered on OSX while trying to
    upgrade to a new V8 version.
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #38899
    Backport-PR-URL: #42512
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mhdawson authored and richardlau committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    e23c04f View commit details
    Browse the repository at this point in the history
  9. node-api: cctest on v8impl::Reference

    PR-URL: #38970
    Backport-PR-URL: #42512
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
    legendecas authored and richardlau committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    5f104e3 View commit details
    Browse the repository at this point in the history
  10. doc: add release key for Danielle Adams

    Add Danielle Adams's release key.
    
    PR-URL: #35545
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    danielleadams authored and richardlau committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    a9c38f1 View commit details
    Browse the repository at this point in the history
  11. doc: update release key for Danielle Adams

    PR-URL: #36793
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    danielleadams authored and richardlau committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    11aef2a View commit details
    Browse the repository at this point in the history
  12. doc: use openpgp.org for keyserver examples

    The sks-keyservers.net is no longer listed by DNS
    
    PR-URL: #39227
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    nschonni authored and richardlau committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    518a49c View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2022

  1. doc: add a note about possible missing lines to readline.asyncIterator

    Fixes: #33463
    
    PR-URL: #34675
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    mikhalev-im authored and richardlau committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    333eda8 View commit details
    Browse the repository at this point in the history
  2. 2022-04-05, Version 12.22.12 'Erbium' (LTS)

    Notable changes:
    
    This is planned to be the final Node.js 12 release. Node.js 12 will
    reach End-of-Life status on 30 April 2022, after which it will no
    receive updates. You are strongly advised to migrate your applications
    to Node.js 16 or 14 (both of which are Long Term Support (LTS) releases)
    to continue to receive future security updates beyond 30 April 2022.
    
    This release fixes a shutdown crash in Node-API (formerly N-API) and a
    potential stack overflow when using `vm.runInNewContext()`.
    
    The list of GPG keys used to sign releases and instructions on how to
    fetch the keys for verifying binaries has been synchronized with the
    main branch.
    
    PR-URL: #42531
    richardlau committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    a3d2837 View commit details
    Browse the repository at this point in the history