Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V14.19.2 proposal #42899

Merged
merged 14 commits into from
May 4, 2022
Merged

V14.19.2 proposal #42899

merged 14 commits into from
May 4, 2022

Conversation

juanarbol
Copy link
Member

@juanarbol juanarbol commented Apr 28, 2022

Notable Changes

doc:

  • New release key for Bryan English

Learn more at: #42102
Contributed by Bryan English (@bengl)

npm:

  • Upgrade npm to v6.14.17.

Learn more at: #42900
Contributed by Ruy Adorno (@ruyadorno)

V8:

  • V8 had a stack overflow issue affecting the vm module, cherry-picking cc9a8a37445e
    from V8 solves this issue.

Learn more at: #41826
Contributed by Gus Caplan (@devsnek)

  • Using getHeapSnapshot() was causing a Node.js crash due a V8 issue, this is fixed by backporting 367b0c1e7a32
    from V8.

Learn more at: #42637
Contributed by Chengzhong Wu (@legendecas)

Commits

  • [c73ac527d6] - build: set DESTCPU correctly for 'make binary' on Apple Silicon (Chris Heisterkamp) #40147
  • [dcaed6db24] - build: use ccache in make-v8.sh on ppc64le and s390x (Richard Lau) #42204
  • [4203d132b1] - child_process: queue pending messages (Erick Wendel) #41221
  • [a3ebdbfe8f] - deps: upgrade npm to 6.14.17 (Ruy Adorno) #42900
  • [39e44f8382] - deps: V8: cherry-pick cc9a8a37445e (Gus Caplan) #41826
  • [b52a268b6f] - deps: V8: cherry-pick 367b0c1e7a32 (legendecas) #42637
  • [77ba012065] - doc: fix documentation of FileHandle.prototype.appendFile (Antoine du Hamel) #42588
  • [3d3d7ed1b7] - doc: specify flag needed for JSON and Wasm modules (Rich Trott) #42736
  • [542d812c93] - doc: use openpgp.org for keyserver examples (Nick Schonning) #39227
  • [7f2825b1a9] - doc: add release key for Bryan English (Bryan English) #42102
  • [75302d3dce] - fs: fix write methods param validation and docs (Livia Medeiros) #41677
  • [d4171e0eac] - stream: resume stream on drain (Robert Nagy) #41848
  • [de474c8b6f] - worker: do not send message if port is closing (Rich Trott) #42357

bengl and others added 2 commits March 17, 2022 19:31
Adds Bryan English and his public key to the README for releases.

PR-URL: #42102
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Previously we would just resume "flowing" the stream without
reseting the "paused" state. Fixes this by properly using
pause/resume methods for .pipe.

Fixes: #41785

PR-URL: #41848
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/modules
  • @nodejs/streams
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v14.x labels Apr 28, 2022
@juanarbol
Copy link
Member Author

cc @nodejs/releasers

I'm not entirely sure about the notable changes; I'm not sure of anything. Please let me know if I missed something or made something wrong.

README.md Outdated Show resolved Hide resolved
common.gypi Outdated Show resolved Hide resolved
@aduh95
Copy link
Contributor

aduh95 commented Apr 28, 2022

Can we include #42840 as well please?

@juanarbol
Copy link
Member Author

Can we include #42840 as well please?

Sure, I forgot to ask, is ok to land without CI? That's why I skiped this one, sorry.

@ruyadorno
Copy link
Member

I forgot to ask, is ok to land without CI?

You should ideally wait for it.

I know it's a bit of a last minute addition, so it's fine if you prefer not to but I believe it would also be nice to include: #42900

@aduh95
Copy link
Contributor

aduh95 commented Apr 28, 2022

#42603 is also a good candidate (even though it lacks approval so far): it fixes a process abort, I assume that's the kind of fixes we want to have landed sooner rather than later.

@juanarbol
Copy link
Member Author

I forgot to ask, is ok to land without CI?

You should ideally wait for it.

I know it's a bit of a last minute addition, so it's fine if you prefer not to but I believe it would also be nice to include: #42900

No worries, this is a proposal, sure I can add both, and I will keep an eye over #42840 and, #42900.

Does that work for all of us?

@juanarbol
Copy link
Member Author

#42603 is also a good candidate (even though it lacks approval so far): it fixes a process abort, I assume that's the kind of fixes we want to have landed sooner rather than later.

Approved, and yes! I'm will include that one as well. Thanks for taking care of kicking CI in both PRs and these suggestions as well.

@aduh95
Copy link
Contributor

aduh95 commented Apr 28, 2022

FWIW #41855 looks to be ready as well.

@legendecas
Copy link
Member

nit: my name is Chengzhong Wu ^^

@juanarbol
Copy link
Member Author

nit: my name is Chengzhong Wu ^^

Oooh, I'm sorry; It was a bit late for the moment I wrote that; sorry, my mistake. I will fix that one, sorry again

@VoltrexKeyva VoltrexKeyva added release Issues and PRs related to Node.js releases. v14.x and removed v14.x lib / src Issues and PRs related to general changes in the lib or src directory. labels Apr 29, 2022
nschonni and others added 4 commits May 1, 2022 16:44
The sks-keyservers.net is no longer listed by DNS

PR-URL: #39227
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
If `ccache` is available, use it during V8 builds on ppc64le and s390x.
Only create the `gcc` and `g++` shims if necessary.

PR-URL: #42204
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: #42296

PR-URL: #42357
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #42736
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@nodejs-github-bot
Copy link
Collaborator

@targos
Copy link
Member

targos commented May 3, 2022

FWIW I personally dislike using @mention in commit messages because it is a source of unwanted notifications when people cherry-pick commits to other repositories.

@juanarbol
Copy link
Member Author

FWIW I personally dislike using @mention in commit messages because it is a source of unwanted notifications when people cherry-pick commits to other repositories.

I can fully understand; sorry about the unwanted noise. Let me fix that one too.

juanarbol added a commit that referenced this pull request May 3, 2022
Notable Changes

doc:

* New release key for Bryan English

Learn more at: #42102
Contributed by Bryan English (bengl)

npm:

* Upgrade `npm` to `v6.14.17`.

Learn more at: #42900
Contributed by Ruy Adorno (ruyadorno)

V8:

* V8 had a stack overflow issue affecting the `vm` module,
cherry-picking `cc9a8a37445e`
(v8/v8@cc9a8a3)
from V8 solves this issue.

Learn more at: #41826
Contributed by Gus Caplan (devsnek)

* Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue,
this is fixed by backporting `367b0c1e7a32`
(v8/v8@367b0c1)
from V8.

Learn more at: #42637
Contributed by Chengzhong Wu (legendecas)

PR-URL: #42899
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@BethGriggs
Copy link
Member

@BethGriggs
Copy link
Member

I'm slightly suspicious of JSONStream-v1.3.5 and acorn-v8.7.1 failing across multiple platforms in CITGM.

@BethGriggs
Copy link
Member

Running CITGM on v14.19.1 as a comparison - https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2930/console

Notable Changes

doc:

* New release key for Bryan English

Learn more at: #42102
Contributed by Bryan English (bengl)

npm:

* Upgrade `npm` to `v6.14.17`.

Learn more at: #42900
Contributed by Ruy Adorno (ruyadorno)

V8:

* V8 had a stack overflow issue affecting the `vm` module,
cherry-picking `cc9a8a37445e`
(v8/v8@cc9a8a3)
from V8 solves this issue.

Learn more at: #41826
Contributed by Gus Caplan (devsnek)

* Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue,
this is fixed by backporting `367b0c1e7a32`
(v8/v8@367b0c1)
from V8.

Learn more at: #42637
Contributed by Chengzhong Wu (legendecas)

PR-URL: #42899
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 4, 2022

@BethGriggs
Copy link
Member

juanarbol added a commit that referenced this pull request May 4, 2022
@juanarbol juanarbol merged commit e365bec into v14.x May 4, 2022
juanarbol added a commit that referenced this pull request May 4, 2022
Notable Changes

doc:

* New release key for Bryan English

Learn more at: #42102
Contributed by Bryan English (bengl)

npm:

* Upgrade `npm` to `v6.14.17`.

Learn more at: #42900
Contributed by Ruy Adorno (ruyadorno)

V8:

* V8 had a stack overflow issue affecting the `vm` module,
cherry-picking `cc9a8a37445e`
(v8/v8@cc9a8a3)
from V8 solves this issue.

Learn more at: #41826
Contributed by Gus Caplan (devsnek)

* Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue,
this is fixed by backporting `367b0c1e7a32`
(v8/v8@367b0c1)
from V8.

Learn more at: #42637
Contributed by Chengzhong Wu (legendecas)

PR-URL: #42899
@juanarbol juanarbol deleted the v14.19.2-proposal branch May 4, 2022 17:11
juanarbol added a commit to juanarbol/nodejs.org that referenced this pull request May 4, 2022
juanarbol added a commit to juanarbol/nodejs.org that referenced this pull request May 4, 2022
BethGriggs pushed a commit to nodejs/nodejs.org that referenced this pull request May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. release Issues and PRs related to Node.js releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.