Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib,test: enable wasm/webapi/empty-body WPT #42960

Merged
merged 1 commit into from
May 5, 2022

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented May 3, 2022

Refs: #42701
Refs: nodejs/undici#1346
Refs: #42939

@tniessen tniessen added the wasm Issues and PRs related to WebAssembly. label May 3, 2022
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label May 3, 2022
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 3, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 3, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 4, 2022
@nodejs-github-bot
Copy link
Collaborator

@@ -250,8 +250,11 @@ function setupFetch() {
}

// Pass all data from the response body to the WebAssembly compiler.
for await (const chunk of response.body) {
streamState.push(chunk);
const { body } = response;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separately, it would be nice to just have this entire function in another JS file and load it into pre_execution.js to keep the routine focusing on bootstrap.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, will do that once this lands.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #42993.

@tniessen tniessen added request-ci Add this label to start a Jenkins CI on a PR. commit-queue Add this label to land a pull request using GitHub Actions. and removed request-ci Add this label to start a Jenkins CI on a PR. labels May 5, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 5, 2022
@nodejs-github-bot nodejs-github-bot merged commit 55079bb into nodejs:master May 5, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 55079bb

tniessen added a commit to tniessen/node that referenced this pull request May 6, 2022
tniessen added a commit to tniessen/node that referenced this pull request May 6, 2022
nodejs-github-bot pushed a commit that referenced this pull request May 8, 2022
Refs: #42960 (comment)

PR-URL: #42993
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 10, 2022
Refs: #42701
Refs: nodejs/undici#1346
Refs: #42939

PR-URL: #42960
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 10, 2022
Refs: #42960 (comment)

PR-URL: #42993
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request May 10, 2022
@juanarbol
Copy link
Member

Backport refs: #42701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. wasm Issues and PRs related to WebAssembly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants