doc: fix formatting in LICENSE for RTF generation #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current format does not render properly when converted to RTF by the tools/license2rtf.js tool, specifically the wrong sections are presented as bold, giving the wrong emphasis to the document. This fix makes the formatting more consistent, with non-license summary sections bold and the licenses themselves unformatted.
|
Rubber-stamp LGTM. |
|
I was surprised to find out that license2rtf is still in use. It would make sense write the license file in markdown, and use a standard markdown-to-rtf tool to produce an RTF for the installers. But it's totally not a priority. lgtm and landed in eec4c81 |
rvagg
added a commit
that referenced
this pull request
Jan 15, 2015
Current format does not render properly when converted to RTF by the tools/license2rtf.js tool, specifically the wrong sections are presented as bold, giving the wrong emphasis to the document. This fix makes the formatting more consistent, with non-license summary sections bold and the licenses themselves unformatted. PR: #436 Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-by: Bert Belder <bertbelder@gmail.com>
|
@bnoordhuis agreed, but I don't care enough about the windows installer nor about licenses in general to do anything more than make it look acceptable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current format does not render properly when converted to RTF by
the tools/license2rtf.js tool, specifically the wrong sections are
presented as bold, giving the wrong emphasis to the document.
This fix makes the formatting more consistent, with non-license
summary sections bold and the licenses themselves unformatted.