Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix spelling error in lib/url.js #4390

Closed
wants to merge 1 commit into from
Closed

Conversation

nikolas
Copy link
Contributor

@nikolas nikolas commented Dec 22, 2015

No description provided.

@mscdex mscdex added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Dec 22, 2015
@Qard
Copy link
Member

Qard commented Dec 29, 2015

LGTM

2 similar comments
@MylesBorins
Copy link
Contributor

LGTM

@jasnell
Copy link
Member

jasnell commented Dec 30, 2015

LGTM

jasnell pushed a commit that referenced this pull request Dec 30, 2015
PR-URL: #4390
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Dec 30, 2015

Landed in 46eee30

@jasnell jasnell closed this Dec 30, 2015
@rvagg
Copy link
Member

rvagg commented Jan 4, 2016

Thanks for spotting and fixing this @nikolas, even small changes like this are appreciated. I believe this is your fist commit to core, congrats on that and welcome on board. I hope you can find other ways to contribute around here!

Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
PR-URL: nodejs#4390
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 7, 2016
PR-URL: #4390
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
PR-URL: #4390
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
PR-URL: nodejs#4390
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants