Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix parallel/test-cluster-primary-error.js #44066

Closed

Conversation

theanarkh
Copy link
Contributor

try to fix parallel/test-cluster-primary-error.js
Refs: #43970
Refs: #39655

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 31, 2022
@theanarkh theanarkh force-pushed the fix_test_cluster_primary_error branch from 7fa9a44 to ae7be08 Compare July 31, 2022 08:36
@aduh95 aduh95 requested a review from addaleax July 31, 2022 09:03
@tniessen
Copy link
Member

Is this test known to fail in non-ASan builds?

@theanarkh
Copy link
Contributor Author

I have not noticed that. I often see this case fail, so I try to fix it.

@tniessen
Copy link
Member

I know it flakes in ASan a lot. But I am not sure if I ever saw it fail on any other system, and I don't see any records of it in nodejs/reliability. So if PID reuse is the issue, I am wondering why this only seems to happen under ASan.

(IIRC, PID reuse is somewhat unlikely with newer Linux kernels.)

@theanarkh
Copy link
Contributor Author

theanarkh commented Jul 31, 2022

I will keep an eye for this test case to see if it will fail on other systems.

@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 28, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 28, 2022
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@theanarkh theanarkh force-pushed the fix_test_cluster_primary_error branch from ae7be08 to 18f5997 Compare December 21, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants