Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: update TextEncoderStream to align with the latest spec #44101

Merged
merged 3 commits into from
Aug 4, 2022
Merged

stream: update TextEncoderStream to align with the latest spec #44101

merged 3 commits into from
Aug 4, 2022
+66 −8

Conversation

cola119
Copy link
Member

@cola119 cola119 commented Aug 2, 2022 •
edited
Loading

This PR updated TextEncoderStream implementation to align with the latest WHATWG spec.

Test cases of /test/fixtures/wpt/encoding/streams/encode-utf8.any.js (WPT for TextEncoderStream) are all passed now. (The previous implementation didn't support surrogate pairs.)

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 2, 2022
aduh95
aduh95 reviewed Aug 2, 2022
View reviewed changes
lib/internal/webstreams/encoding.js Outdated
Comment on lines 6 to 7
Uint8Array,
String
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Uint8Array,
String
String,
Uint8Array,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done f2304b6

@cola119 cola119 requested a review from aduh95 August 2, 2022 23:53
@cola119 cola119 requested a review from aduh95 August 3, 2022 09:16
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 3, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 3, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45818/

@cola119 cola119 mentioned this pull request Aug 3, 2022
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45824/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45832/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 4, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 4, 2022
@nodejs-github-bot nodejs-github-bot merged commit c8bea71 into nodejs:main Aug 4, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in c8bea71

This was referenced Aug 5, 2022
Open
Open
Open
Open
danielleadams pushed a commit that referenced this pull request Aug 16, 2022
@cola119 @danielleadams
stream: update TextEncoderStream to align the latest spec
e057480 
PR-URL: #44101
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Aug 16, 2022
Closed