Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix ssize_t error from nghttp2.h #44393

Merged
merged 2 commits into from
Aug 29, 2022
Merged

src: fix ssize_t error from nghttp2.h #44393

merged 2 commits into from
Aug 29, 2022

Commits on Aug 26, 2022

  1. src: fix ssize_t error from nghttp2.h 

    The "node_http2.h" include reordering enforced by clang-format broke
Electron's Node.js upgrade on Windows. ssize_t is a part of the POSIX
standard and it's not available on Windows, so the fix for this is to
include "node.h" which typedefs it on Windows in
https://github.com/nodejs/node/blob/bb4dff783ddb3b20c67041f7ccef796c335c2407/src/node.h#L212-L220.

Refs: electron/electron#35350 (comment)
Signed-off-by: Darshan Sen <raisinten@gmail.com>
    @RaisinTen
    RaisinTen committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    c4f9a6e View commit details
    Browse the repository at this point in the history

  2. src: resolve stdint.h FIXME 

    Co-authored-by: Anna Henningsen <github@addaleax.net>
    @RaisinTen @addaleax
    RaisinTen and addaleax committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    a6573ba View commit details
    Browse the repository at this point in the history