Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v18.9.0 release proposal #44521

Merged
merged 94 commits into from
Sep 8, 2022
Merged

v18.9.0 release proposal #44521

merged 94 commits into from
Sep 8, 2022

Conversation

RafaelGSS
Copy link
Member

@RafaelGSS RafaelGSS commented Sep 5, 2022

2022-09-08, Version 18.9.0 (Current), @RafaelGSS

Notable changes

Commits

  • [e27e709d3c] - build: add --libdir flag to configure (Stephen Gallagher) #44361
  • [30da2b4d89] - build: added NINJA env to customize ninja binary (Jeff Dickey) #44293
  • [3c5354869e] - cluster: fix cluster rr distribute error (theanarkh) #44202
  • [5cefd02618] - crypto: handle invalid prepareAsymmetricKey JWK inputs (Filip Skokan) #44475
  • [c868e36385] - crypto: add digest name to INVALID_DIGEST errors (Tobias Nießen) #44468
  • [35cbe1ad85] - crypto: use actual option name in error message (Tobias Nießen) #44455
  • [c3dbe18e4c] - crypto: simplify control flow in HKDF (Tobias Nießen) #44272
  • [28781a1f7e] - crypto: improve RSA-PSS digest error messages (Tobias Nießen) #44307
  • [b1eafe14fd] - debugger: decrease timeout used to wait for the port to be free (Joyee Cheung) #44359
  • [8ef5c40a83] - deps: update corepack to 0.14.0 (Node.js GitHub Bot) #44509
  • [cf19a79dfc] - deps: upgrade npm to 8.19.1 (npm team) #44486
  • [c5630ad1a7] - deps: V8: backport ff8d67c88449 (Michaël Zasso) #44423
  • [255e7fbd08] - deps: update Acorn to v8.8.0 (Michaël Zasso) #44437
  • [754d26a53e] - deps: patch V8 to 10.2.154.15 (Michaël Zasso) #44294
  • [1b50ff2600] - deps: update icu tzdata to 2022b (Matías Zúñiga) #44283
  • [1e451dca99] - deps: upgrade llhttp to 6.0.9 (Paolo Insogna) #44344
  • [57da3db522] - deps: update undici to 5.9.1 (Node.js GitHub Bot) #44319
  • [1c87a7e8f6] - doc: add missing parenthesis in TLSSocket section (Tobias Nießen) #44512
  • [05006eddb2] - doc: do not use "Returns:" for crypto.constants (Tobias Nießen) #44481
  • [54b6ed58bc] - doc: use serial comma in addons docs (Tobias Nießen) #44482
  • [11452a97b3] - doc: add --update-assert-snapshot to node.1 (Colin Ihrig) #44429
  • [ae028e8ac3] - doc: improve assert.snapshot() docs (Colin Ihrig) #44429
  • [71c869688a] - doc: add missing imports in events sample code (Brian Evans) #44337
  • [92046e8027] - doc: apply scroll-margin-top to h2, h3 elements (metonym) #44414
  • [3e6cde5931] - doc: fix spacing issue in --build-snapshot help text (Shohei YOSHIDA) #44435
  • [8e41dbb81b] - doc: mention cherry-pick edge-case on release (RafaelGSS) #44408
  • [cef30f9afc] - doc: note on release guide to update main branch (Ruy Adorno) #44384
  • [21437f7a7f] - doc: fix release guide example consistency (Ruy Adorno) #44385
  • [ed52bd0a18] - doc: fix style of n-api.md (theanarkh) #44377
  • [65c1f4015f] - doc: add history for net.createServer() options (Luigi Pinca) #44326
  • [4a0f750a6c] - doc: add daeyeon to collaborators (Daeyeon Jeong) #44355
  • [8cc5556f76] - doc: fix typo in test runner code examples (Moshe Atlow) #44351
  • [b660b7467d] - doc,worker: document resourceLimits overrides (Keyhan Vakil) #43992
  • [2ed3b30696] - inspector: prevent integer overflow in open() (Tobias Nießen) #44367
  • [b8f08e5e7e] - lib: codify findSourceMap return value when not found (Chengzhong Wu) #44397
  • [a86ef1ba3e] - lib: use safe Promise alternatives when available (Antoine du Hamel) #43476
  • [e519ac7842] - meta: update AUTHORS (Node.js GitHub Bot) #44511
  • [c03f28b960] - meta: update AUTHORS (Node.js GitHub Bot) #44422
  • [ef08cbddac] - node-api: avoid calling virtual methods in base's dtor (Chengzhong Wu) #44424
  • [256340197c] - node-api: cleanup redundant static modifiers (Chengzhong Wu) #44301
  • [6714736706] - (SEMVER-MINOR) os: add machine method (theanarkh) #44416
  • [807b1e5533] - report: get stack trace with cross origin contexts (Chengzhong Wu) #44398
  • [b17cc877d0] - report: fix missing section javascriptHeap on OOMError (Chengzhong Wu) #44398
  • [1f23c17ae0] - (SEMVER-MINOR) report: expose report public native apis (Chengzhong Wu) #44255
  • [df259005d9] - report: add queue info for udp (theanarkh) #44345
  • [fc17b808c9] - src: rename misleading arg in ClientHelloParser (Tobias Nießen) #44500
  • [125ab7da2a] - src: improve error handling in CloneSSLCerts (Tobias Nießen) #44410
  • [aa34f7347b] - src: fix incorrect comments in crypto (Tobias Nießen) #44470
  • [18b720805f] - src: avoid casting std::trunc(... / ...) to size_t (Tobias Nießen) #44467
  • [4331bbe2af] - (SEMVER-MINOR) src: expose environment RequestInterrupt api (Chengzhong Wu) #44362
  • [c5413a1146] - src: simplify enable_if logic of ToStringHelper::BaseConvert (Feng Yu) #44306
  • [dcc1cf4f4e] - src: add error handling to uv_uptime call (Juan José Arboleda) #44386
  • [fd611cc272] - src: remove base64_select_table and base64_table (Tobias Nießen) #44425
  • [4776b4767b] - src: fix uv_err_name memory leak (theanarkh) #44421
  • [8db2e66d3a] - src: make Endianness an enum class (Tobias Nießen) #44411
  • [048e440878] - src: fix ssize_t error from nghttp2.h (Darshan Sen) #44393
  • [dc1c95ede3] - src: trace fs async api (theanarkh) #44057
  • [0f4e98ba2c] - src: restore context default IsCodeGenerationFromStringsAllowed value (Chengzhong Wu) #44324
  • [05fb650b54] - src: simplify and optimize GetOpenSSLVersion() (Tobias Nießen) #44395
  • [7f16177f96] - src: use if constexpr where appropriate (Anna Henningsen) #44291
  • [2be8acad18] - src: simplify ECDH::GetCurves() (Tobias Nießen) #44309
  • [3eb7918f8e] - src: make minor improvements to EnabledDebugList (Tobias Nießen) #44350
  • [88d9566593] - src: remove KeyObjectData::symmetric_key_len_ (Tobias Nießen) #44346
  • [768c9cb872] - src: fix multiple format string bugs (Tobias Nießen) #44314
  • [6857ee8299] - src: make minor improvements to SecureBuffer (Tobias Nießen) #44302
  • [2facf8b8e0] - stream: fix setting abort reason in ReadableStream.pipeTo() (Daeyeon Jeong) #44418
  • [65134d696b] - stream: fix ReadableStreamReader.releaseLock() (Daeyeon Jeong) #44292
  • [4c33e5d4ce] - test: avoid race in file write stream handle tests (Joyee Cheung) #44380
  • [0d77342a39] - test: style updates for assert.snapshot() (Colin Ihrig) #44429
  • [e36ed44b26] - test: deflake child process exec timeout tests (Joyee Cheung) #44390
  • [0af15c71fb] - test: make the vm timeout escape tests more lenient (Joyee Cheung) #44433
  • [0f071b800e] - test: split heap prof tests (Joyee Cheung) #44388
  • [2dd88b8425] - test: fix multiple incorrect mustNotCall() uses (Tobias Nießen) #44022
  • [4ae1f4990c] - test: split report OOM tests (Joyee Cheung) #44389
  • [3a5fdacdc2] - test: fix WPT runner result (Daeyeon Jeong) #44238
  • [e001aafee3] - test: raise sleep times in child process tests (Joyee Cheung) #44375
  • [8e2dcafc24] - test: remove duplicate test (Luigi Pinca) #44313
  • [c65d7fb1fa] - test: add OpenSSL 3.x providers test (Richard Lau) #44148
  • [11e9d6e173] - test: make tmpdir.js importable from esm (Geoffrey Booth) #44322
  • [a35c2f9ef4] - test_runner: fix duration_ms to be milliseconds (Moshe Atlow) #44450
  • [8175c65b4d] - test_runner: support programmatically running --test (Moshe Atlow) #44241
  • [1cdccbc845] - tls: remove SecureContext setFreeListLength (Tobias Nießen) #44300
  • [70399166f3] - tls: use OpenSSL constant for client random size (Tobias Nießen) #44305
  • [6fe189b62a] - tools: update lint-md-dependencies to rollup@2.79.0 (Node.js GitHub Bot) #44510
  • [1e62bb14dd] - tools: fix typo in avoid-prototype-pollution lint rule (Antoine du Hamel) #44446
  • [78c6827688] - tools: don't use f-strings in test.py (Santiago Gimeno) #44407
  • [443730c419] - tools: update doc to unist-util-visit@4.1.1 (Node.js GitHub Bot) #44370
  • [96df99375e] - tools: update eslint to 8.23.0 (Node.js GitHub Bot) #44419
  • [b6709544e9] - tools: refactor avoid-prototype-pollution lint rule (Antoine du Hamel) #43476
  • [8b0a4afcae] - tty: fix TypeError when stream is closed (Antoine du Hamel) #43803
  • [c4a45a93f3] - vm: avoid unnecessary property getter interceptor calls (Joyee Cheung) #44252
  • [736a04aa13] - vm: include vm context in the embedded snapshot (Joyee Cheung) #44252
  • [bce827e5d1] - vm: make ContextifyContext template context-independent (Joyee Cheung) #44252

jdx and others added 30 commits September 5, 2022 11:32
Fixes: #44286
PR-URL: #44293
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Avoid magic numbers in the code and use an OpenSSL constant instead.

PR-URL: #44305
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
This function was introduced in 2684c90
as an internal helper function. The C++ implementation became a no-op in
a57e2f2 when building against OpenSSL
1.1.0 (instead of OpenSSL 1.0.2), and eventually became a no-op in all
supported OpenSSL versions in 970ce14.
Finally, eb20447 removed the only call
site of setFreeListLength (which was already a no-op at that point).

Refs: #1529
Refs: #10859
Refs: #19794
Refs: #38116
PR-URL: #44300
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Remove an unnecessary static_cast<char*>().

Use OPENSSL_secure_zalloc() instead of OPENSSL_secure_malloc() +
memset().

Update the comment describing the function which predates support for
OpenSSL's secure heap.

PR-URL: #44302
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
md and mgf1_md are internal variable names and should not appear in
JS error messages. Also include the invalid digest name in the error
message.

PR-URL: #44307
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The THROW_ERR_* functions interpret the first argument as a printf-like
format string, which is problematic when it contains unsanitized user
input. This typically happens when a printf-like function is used to
produce the error message, which is then passed to a THROW_ERR_*
function, which again interprets the error message as a format string.

Fix such occurrences by properly formatting error messages using static
format strings only, and in a single step.

PR-URL: #44314
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #44322
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ian Sutherland <ian@iansutherland.ca>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #44351
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
PR-URL: #44355
Fixes: #44142
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Fixes: #44298
PR-URL: #44326
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Instead of creating an object template for every ContextifyContext,
we now create one object template that can be reused by all
contexts. The native pointer can be obtained through an embdder
pointer field in the creation context of the receiver in the
interceptors, because the interceptors are only meant to be invoked
on the global object of the contextified contexts. This makes
the ContextifyContext template context-independent and therefore
snapshotable.

PR-URL: #44252
Refs: #44014
Refs: #37476
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Include a minimally initialized contextify context in the embedded
snapshot. This paves the way for user-land vm context snapshots.

PR-URL: #44252
Refs: #44014
Refs: #37476
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Access to the global object from within a vm context is intercepted
so it's slow, therefore we should try to avoid unnecessary access
to it during the initialization of vm contexts.

- Remove the Atomics.wake deletion as V8 now does not install it
  anymore.
- Move the Intl.v8BreakIterator deletion into the snapshot.
- Do not query the Object prototype if --disable-proto is not set.

This should speed up the creation of vm contexts by about ~12%.

PR-URL: #44252
Refs: #44014
Refs: #37476
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
PR-URL: #44319
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #44241
Fixes: #44023
Fixes: #43675
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
By default, the debugger would query the specified inspector
sever port to see if it's available before starting the server,
and it would keep retrying until a timeout (previously 9999 ms)
is reached. This timeout seems to be longer than necessary. This
patch decreases the timeout to 3 seconds.

PR-URL: #44359
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Richard Lau <rlau@redhat.com>
Add basic tests for providers when using OpenSSL 3.x.

PR-URL: #44148
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #44345
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Allows APM vendors to generate a diagnostic report without calling into
JavaScript. Like, from their own message channels interrupting the
isolate and generating a report on demand.

PR-URL: #44255
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Fixes: #41330
PR-URL: #43803
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
symmetric_key_len_ is always equal to symmetric_key_.size(). Storing it
separately is redundant and has no significant benefit.

PR-URL: #44346
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
The test in `test/parallel/test-stream-writable-callback-twice.js` is
duplicated in `test/parallel/test-stream-writable-write-cb-twice.js`.

PR-URL: #44313
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Functions declared in anonymous namespaces are not necessarily to be
marked as static.

PR-URL: #44301
Refs: #44141
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Change the underlying type of DebugCategory to unsigned int so that it
can be safely cast to an unsigned type without having to worry about
negative values, removing the need for the DCHECK_GE statements.

To fully benefit from type safety, remove DebugCategory::CATEGORY_COUNT
and instead add a constexpr kDebugCategoryCount.

Remove the second argument from EnabledDebugList::set_enabled() and
EnabledDebugList::Parse() because it was always set to true.

PR-URL: #44350
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #44377
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #44344
Fixes: #43115
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
sequential/test-child-process-execsync and
parallel/test-child-process-spawnsync-timeout are both flaky
on azure Windows machines, where it may take longer for Node.js
to launch and receive output from child processes. These tests
work by spawning a child processes that is supposed to sleep
for a long time, but the option is configured so that Node.js
would terminate them early when a shorter timeout is reached.
Then the tests assert that the time taken for the whole thing
is shorter than the specified sleep time (meaning the process
don't actually get to sleep for that long). To make the tests
less brittle on azure Windows, this patch raises the sleep
times in those tests on Windows platform, so that the overhead
can be taken into account there.

PR-URL: #44375
Refs: nodejs/build#3014
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Unify the implementation and perform the same OpenSSL calls regardless
of whether the key and/or salt are empty. This simplifies the code and
improves coverage.

Refs: #44201
PR-URL: #44272
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
PR-URL: #44367
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
This doesn't include the other tests for the result when
running a specific test in WPT.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
PR-URL: #44238
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@RafaelGSS
Copy link
Member Author

FYI: The build took more time than expected. I'll release it tomorrow.

RafaelGSS added a commit that referenced this pull request Sep 7, 2022
Notable changes:

* doc:
  * add daeyeon to collaborators (Daeyeon Jeong) #44355
* lib:
  * (SEMVER-MINOR) add diagnostics channel for process and worker (theanarkh) #44045
* os:
  * (SEMVER-MINOR) add machine method (theanarkh) #44416
* report:
  * (SEMVER-MINOR) expose report public native apis (Chengzhong Wu) #44255
* src:
  * (SEMVER-MINOR) expose environment RequestInterrupt api (Chengzhong Wu) #44362
* vm:
  * include vm context in the embedded snapshot (Joyee Cheung) #44252

PR-URL: #44521
Notable changes:

* doc:
  * add daeyeon to collaborators (Daeyeon Jeong) #44355
* lib:
  * (SEMVER-MINOR) add diagnostics channel for process and worker (theanarkh) #44045
* os:
  * (SEMVER-MINOR) add machine method (theanarkh) #44416
* report:
  * (SEMVER-MINOR) expose report public native apis (Chengzhong Wu) #44255
* src:
  * (SEMVER-MINOR) expose environment RequestInterrupt api (Chengzhong Wu) #44362
* vm:
  * include vm context in the embedded snapshot (Joyee Cheung) #44252

PR-URL: #44521
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 7, 2022

@nodejs-github-bot
Copy link
Collaborator

@RafaelGSS
Copy link
Member Author

@RafaelGSS RafaelGSS merged commit 9ae2af4 into v18.x Sep 8, 2022
@RafaelGSS RafaelGSS deleted the v18.9.0-proposal branch September 8, 2022 14:30
RafaelGSS added a commit that referenced this pull request Sep 8, 2022
RafaelGSS added a commit that referenced this pull request Sep 8, 2022
Notable changes:

* doc:
  * add daeyeon to collaborators (Daeyeon Jeong) #44355
* lib:
  * (SEMVER-MINOR) add diagnostics channel for process and worker (theanarkh) #44045
* os:
  * (SEMVER-MINOR) add machine method (theanarkh) #44416
* report:
  * (SEMVER-MINOR) expose report public native apis (Chengzhong Wu) #44255
* src:
  * (SEMVER-MINOR) expose environment RequestInterrupt api (Chengzhong Wu) #44362
* vm:
  * include vm context in the embedded snapshot (Joyee Cheung) #44252

PR-URL: #44521
RafaelGSS added a commit to RafaelGSS/nodejs.org that referenced this pull request Sep 8, 2022
RafaelGSS added a commit to nodejs/nodejs.org that referenced this pull request Sep 8, 2022
@sgallagher
Copy link
Contributor

It looks like the merge of e27e709d3c accidentally removed some code necessary for systemtap/dtrace.

@RafaelGSS
Copy link
Member Author

You right. Looks like it conflicted with #43652. I'll apply a patch.

Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
Notable changes:

* doc:
  * add daeyeon to collaborators (Daeyeon Jeong) nodejs#44355
* lib:
  * (SEMVER-MINOR) add diagnostics channel for process and worker (theanarkh) nodejs#44045
* os:
  * (SEMVER-MINOR) add machine method (theanarkh) nodejs#44416
* report:
  * (SEMVER-MINOR) expose report public native apis (Chengzhong Wu) nodejs#44255
* src:
  * (SEMVER-MINOR) expose environment RequestInterrupt api (Chengzhong Wu) nodejs#44362
* vm:
  * include vm context in the embedded snapshot (Joyee Cheung) nodejs#44252

PR-URL: nodejs#44521
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.