Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: expose LookupAndCompile with parameters #45142

Closed

Conversation

codebytere
Copy link
Member

Refs #44018.

This PR exposes a version of LookupAndCompile that takes parameters instead of detecting them based on module IDs.

Electron currently maintains a wrapper to LookupAndCompile, which specifically requires parameters because we pass our own modules to LookupAndCompile in several places:

and therefore need to be able to able to expose the ability to set that.

I do, however, see that Node.js recently added back a version of CompileAndCall which is effectively the same as our own CompileAndCall wrapper, so if it would be better to modify that to allow parameters I would also be happy to take that path.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@codebytere codebytere added the embedding Issues and PRs related to embedding Node.js in another project. label Oct 24, 2022
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 24, 2022
@codebytere codebytere changed the title src: expose LookupAndCompile with parameters src: expose LookupAndCompile with parameters Oct 24, 2022
src/node_builtins.cc Outdated Show resolved Hide resolved
src/node_builtins.h Outdated Show resolved Hide resolved
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@nodejs-github-bot
Copy link
Collaborator

@nodejs nodejs deleted a comment from nodejs-github-bot Nov 8, 2022
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@aduh95
Copy link
Contributor

aduh95 commented May 11, 2024

This needs rebase.

@codebytere
Copy link
Member Author

Superseded by #53886

@codebytere codebytere closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. embedding Issues and PRs related to embedding Node.js in another project. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants