Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: correct the sed command for macOS in release process docs #46397

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

juanarbol
Copy link
Member

The documented sed command was failing in my machine during a release proposal preparation.

sed: 1: "MD-FILE": extra characters at the end of d command

You could see this https://stackoverflow.com/a/62309999 as a ref to the issue of the sed command in macOS which makes the sed command works again in macOS

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 28, 2023
Copy link

@sanqro sanqro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your contribution seems good. Please specify your writing on line 431

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 31, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 31, 2023
@nodejs-github-bot nodejs-github-bot merged commit d5b6a18 into nodejs:main Jan 31, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in d5b6a18

ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
PR-URL: #46397
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 1, 2023
@juanarbol juanarbol deleted the juan/sed-command-update branch February 12, 2023 02:14
juanarbol added a commit that referenced this pull request Mar 3, 2023
PR-URL: #46397
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@juanarbol juanarbol mentioned this pull request Mar 3, 2023
juanarbol added a commit that referenced this pull request Mar 3, 2023
PR-URL: #46397
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
juanarbol added a commit that referenced this pull request Mar 5, 2023
PR-URL: #46397
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants