Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: enforce use of trailing commas in more files #46655

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 14, 2023

Some part of the codebase already use trailing commas, this commit is adding a lint rule to ensure it stays this way.
This commit also adds the rule for a few files that were missing only one or two trailing commas.

Some part of the codebase already use trailing commas, this commit is
adding a lint rule to ensure it stays this way.
This commit also adds the rule for a few files that were missing only
one or two trailing commas.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules
  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Feb 14, 2023
@aduh95
Copy link
Contributor Author

aduh95 commented Feb 16, 2023

/cc @nodejs/linting

@targos
Copy link
Member

targos commented Feb 16, 2023

Are we far from being able to enable it on the whole lib folder?

@aduh95
Copy link
Contributor Author

aduh95 commented Feb 16, 2023

Are we far from being able to enable it on the whole lib folder?

17 commits/PRs away :)

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Feb 16, 2023
@aduh95 aduh95 merged commit cbcefdf into nodejs:main Feb 16, 2023
@aduh95
Copy link
Contributor Author

aduh95 commented Feb 16, 2023

Landed in cbcefdf

@aduh95 aduh95 deleted the lib-dangle-misc branch February 16, 2023 17:47
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
Some part of the codebase already use trailing commas, this commit is
adding a lint rule to ensure it stays this way.
This commit also adds the rule for a few files that were missing only
one or two trailing commas.

PR-URL: #46655
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@MylesBorins MylesBorins mentioned this pull request Feb 19, 2023
MylesBorins pushed a commit that referenced this pull request Feb 20, 2023
Some part of the codebase already use trailing commas, this commit is
adding a lint rule to ensure it stays this way.
This commit also adds the rule for a few files that were missing only
one or two trailing commas.

PR-URL: #46655
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
Some part of the codebase already use trailing commas, this commit is
adding a lint rule to ensure it stays this way.
This commit also adds the rule for a few files that were missing only
one or two trailing commas.

PR-URL: #46655
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants