Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update-nghttp2 preserve config.h #46698

Merged
merged 1 commit into from
Feb 21, 2023
Merged

tools: update-nghttp2 preserve config.h #46698

merged 1 commit into from
Feb 21, 2023

Conversation

marco-ippolito
Copy link
Member

Refs: #45572

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Feb 17, 2023
anonrig
anonrig approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anonrig anonrig requested a review from targos February 17, 2023 14:20
@targos targos linked an issue Feb 20, 2023 that may be closed by this pull request
Script to update nghttp2 doesn't work #45572
Closed
@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 21, 2023
@nodejs-github-bot nodejs-github-bot merged commit 4737a20 into nodejs:main Feb 21, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 4737a20

targos pushed a commit that referenced this pull request Mar 13, 2023
@marco-ippolito @targos
tools: update-nghttp2 preserve config.h
2ff9b20 
PR-URL: #46698
Refs: #45572
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@marco-ippolito @danielleadams
tools: update-nghttp2 preserve config.h
4da3eec 
PR-URL: #46698
Refs: #45572
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Script to update nghttp2 doesn't work
8 participants
@marco-ippolito @nodejs-github-bot @jasnell @lpinca @anonrig @targos @cjihrig @RafaelGSS