Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update lint-md-dependencies to rollup@3.17.0 #46712

Closed

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of lint-md-dependencies to rollup@3.17.0.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Feb 18, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 18, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 20, 2023
@nodejs-github-bot

This comment was marked as outdated.

@MoLow MoLow added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 20, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 20, 2023
@nodejs-github-bot

This comment was marked as outdated.

@MoLow MoLow added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 20, 2023
@MoLow
Copy link
Member

MoLow commented Feb 20, 2023

seems like ncu can use some edge case handling adding retries etc

@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 20, 2023
@nodejs-github-bot

This comment was marked as outdated.

@MoLow MoLow added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 20, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 20, 2023
@nodejs-github-bot
Copy link
Collaborator Author

Commit Queue failed
- Loading data for nodejs/node/pull/46712
✔  Done loading data for nodejs/node/pull/46712
----------------------------------- PR info ------------------------------------
Title      tools: update lint-md-dependencies to rollup@3.17.0 (#46712)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/tools-update-lint-md-dependencies -> nodejs:main
Labels     tools, author ready
Commits    2
 - tools: update lint-md-dependencies to rollup@3.17.0
 - tools: update lint-md-dependencies to rollup@3.17.1
Committers 1
 - Node.js GitHub Bot 
PR-URL: https://github.com/nodejs/node/pull/46712
Reviewed-By: Antoine du Hamel 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Darshan Sen 
Reviewed-By: Moshe Atlow 
Reviewed-By: Rich Trott 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46712
Reviewed-By: Antoine du Hamel 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Darshan Sen 
Reviewed-By: Moshe Atlow 
Reviewed-By: Rich Trott 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 18 Feb 2023 09:03:08 GMT
   ✔  Approvals: 5
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/46712#pullrequestreview-1304507655
   ✔  - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/46712#pullrequestreview-1304588316
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/46712#pullrequestreview-1304593314
   ✔  - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/46712#pullrequestreview-1305414981
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/46712#pullrequestreview-1304670574
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 46712
From https://github.com/nodejs/node
 * branch                  refs/pull/46712/merge -> FETCH_HEAD
✔  Fetched commits as c2039213baa4..16113bbeb7a9
--------------------------------------------------------------------------------
[main 2effb0d666] tools: update lint-md-dependencies to rollup@3.17.0
 Date: Sat Feb 18 09:03:04 2023 +0000
 2 files changed, 6 insertions(+), 1871 deletions(-)
[main b76d463bcd] tools: update lint-md-dependencies to rollup@3.17.1
 Date: Sun Feb 19 00:26:04 2023 +0000
 2 files changed, 5 insertions(+), 5 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
tools: update lint-md-dependencies to rollup@3.17.0

PR-URL: #46712
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com
Reviewed-By: Moshe Atlow moshe@atlow.co.il
Reviewed-By: Rich Trott rtrott@gmail.com

[detached HEAD 4cda849791] tools: update lint-md-dependencies to rollup@3.17.0
Date: Sat Feb 18 09:03:04 2023 +0000
2 files changed, 6 insertions(+), 1871 deletions(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
tools: update lint-md-dependencies to rollup@3.17.1

PR-URL: #46712
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com
Reviewed-By: Moshe Atlow moshe@atlow.co.il
Reviewed-By: Rich Trott rtrott@gmail.com

[detached HEAD 9553cd5235] tools: update lint-md-dependencies to rollup@3.17.1
Date: Sun Feb 19 00:26:04 2023 +0000
2 files changed, 5 insertions(+), 5 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/4222067875

@MoLow MoLow added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 20, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 20, 2023
@nodejs-github-bot
Copy link
Collaborator Author

Landed in c203921...6bc87b7

nodejs-github-bot added a commit that referenced this pull request Feb 20, 2023
PR-URL: #46712
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot added a commit that referenced this pull request Feb 20, 2023
PR-URL: #46712
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos deleted the actions/tools-update-lint-md-dependencies branch February 20, 2023 09:57
targos pushed a commit that referenced this pull request Mar 13, 2023
PR-URL: #46712
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Mar 13, 2023
PR-URL: #46712
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
PR-URL: #46712
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
PR-URL: #46712
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants