Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: add trailing commas in source files #46757

Merged
merged 1 commit into from
Feb 24, 2023
Merged

repl: add trailing commas in source files #46757

merged 1 commit into from
Feb 24, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 22, 2023

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Feb 22, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Feb 22, 2023
@aduh95 aduh95 merged commit e4e8421 into nodejs:main Feb 24, 2023
@aduh95
Copy link
Contributor Author

aduh95 commented Feb 24, 2023

Landed in e4e8421

@aduh95 aduh95 deleted the dangle-repl branch February 24, 2023 08:43
targos pushed a commit that referenced this pull request Mar 13, 2023
@aduh95 @targos
repl: add trailing commas in source files
4f2bf8c 
PR-URL: #46757
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@aduh95 @danielleadams
repl: add trailing commas in source files
91fbad6 
PR-URL: #46757
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@deokjinkim deokjinkim deokjinkim approved these changes

@Ayase-252 Ayase-252 Ayase-252 approved these changes

@MoLow MoLow MoLow approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aduh95 @jasnell @deokjinkim @Ayase-252 @MoLow @trivikr @nodejs-github-bot