tools: ensure daily wpt nightly node version can be installed #46891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
meta
|
Fast-track has been requested by @panva. Please 👍 to approve. |
richardlau
approved these changes
Mar 1, 2023
panva
added
the
author ready
cjihrig
approved these changes
Mar 1, 2023
panva
added
commit-queue
anonrig
approved these changes
Mar 1, 2023
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 3860087 |
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46891 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
PR-URL: #46891 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams
added
the
dont-land-on-v18.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the nightly version query to ensure that a build for platform linux and architecture x64 exists by adding a query to jq, it is now looking for the first listed nightly with
"linux-x64"in files.This will avoid the issue that occurred during the latest run possibly caused by a nightly build failing. See
v20.0.0-nightly202302287a37829ccbin https://nodejs.org/download/nightly/index.json