Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move test-shadow-realm-gc.js to known_issues #47355

Merged
merged 3 commits into from
Apr 4, 2023
Merged

test: move test-shadow-realm-gc.js to known_issues #47355

merged 3 commits into from
Apr 4, 2023

Commits on Apr 1, 2023

  1. test: move test-shadow-realm-gc.js to known_issues 

    There is actually a leak. The test doesn't exercise the right
path to create a substantial enough object graph (e.g.
accessing something that results in the loading of a binding).
This does something more complicated in the test and moves it
to known_issues until we find a fix.
    @joyeecheung
    joyeecheung committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    4e89ddb View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. fixup! test: move test-shadow-realm-gc.js to known_issues

    @joyeecheung
    joyeecheung committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    2b9c917 View commit details
    Browse the repository at this point in the history

  2. fixup! test: move test-shadow-realm-gc.js to known_issues 

    Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
    @joyeecheung @legendecas
    joyeecheung and legendecas committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    e0ea347 View commit details
    Browse the repository at this point in the history