Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: delegate split message to reporter #48140

Closed
wants to merge 1 commit into from
Closed

test_runner: delegate split message to reporter #48140

wants to merge 1 commit into from

Conversation

HinataKah0
Copy link
Contributor

Delegate stdout formatting (splitting message) to reporter

Refs: #48045 (comment)

TODO:

  • Update commit message

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 23, 2023
@MoLow
Copy link
Member

MoLow commented May 23, 2023

@HinataKah0 thanks! but I have already included a very similar change in #48057

@HinataKah0
Copy link
Contributor Author

Yeah, I just saw it. Closing this PR.

@HinataKah0 HinataKah0 closed this May 23, 2023
@HinataKah0 HinataKah0 deleted the delegate-split-message-to-reporter branch May 23, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HinataKah0 @nodejs-github-bot @MoLow