Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: reapply servername on happy eyeballs connect #48255

Merged
merged 1 commit into from
Jun 2, 2023

Commits on May 30, 2023

  1. tls: reapply servername on happy eyeballs connect

    When establishing a TLS connection to a server with `autoSelectFamily`
    set to `true`, the `net.Socket` will call `[kWrapConnectedHandle]()` to
    reinitialize the socket (in case if it got broken during previous
    connect attempts). Unfortunately, prior to this patch this resulted in a
    brand new `TLSWrap` instance being created for the socket. While most of
    the configuration of `TLSWrap` is restored, the `servername` was sadly
    dropped and not reinitalized.
    
    With this patch `servername` will be reinitialized if there are
    `tls.connect` options present on the `TLSSocket` instance, making it
    possible to connect with "Happy Eyeballs" to TLS servers that require
    the servername extension.
    indutny committed May 30, 2023
    Configuration menu
    Copy the full SHA
    32cb089 View commit details
    Browse the repository at this point in the history