Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add additional info on TSFN dispatch #48367

Closed
wants to merge 3 commits into from

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Jun 6, 2023

Refs: #48356

Refs: nodejs#48356

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/node-api

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Jun 6, 2023
@mhdawson
Copy link
Member Author

mhdawson commented Jun 6, 2023

Implementation of dispatch is here:

void Dispatch() {

Currently at least 1 and up to 1000 callbacks in the queue will be invoked, but that I believe should be left as an implementation detail. Doc is updated to indicate that more than one can be invoked in tick, but there is no guarantee as to how many will be in any given tick.

@nodejs/node-api does that seem reasonable to everybody?

doc/api/n-api.md Outdated Show resolved Hide resolved
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
doc/api/n-api.md Outdated Show resolved Hide resolved
Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
mhdawson added a commit that referenced this pull request Jun 12, 2023
Refs: #48356

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #48367
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@mhdawson
Copy link
Member Author

Landed in 1da9099

@mhdawson mhdawson closed this Jun 12, 2023
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
Refs: #48356

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #48367
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Refs: nodejs#48356

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: nodejs#48367
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
Refs: nodejs#48356

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: nodejs#48367
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
ruyadorno pushed a commit that referenced this pull request Sep 7, 2023
Refs: #48356

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #48367
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Sep 8, 2023
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
Refs: #48356

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #48367
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants