Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix notDeepEqual API #4971

Closed
wants to merge 1 commit into from
Closed

doc: fix notDeepEqual API #4971

wants to merge 1 commit into from

Conversation

JungMinu
Copy link
Member

API calls in assert are deepEqual(), not notDeepEqual().
use notDeepEqual to make it clear.

@JungMinu JungMinu added the doc Issues and PRs related to the documentations. label Jan 30, 2016
@JungMinu JungMinu self-assigned this Jan 30, 2016
@mscdex mscdex added the assert Issues and PRs related to the assert subsystem. label Jan 30, 2016
@Trott
Copy link
Member

Trott commented Jan 30, 2016

LGTM

@stevemao
Copy link
Contributor

LGTM

API calls in `assert` are `deepEqual()`, not `notDeepEqual()`.
use `notDeepEqual` to make it clear.

PR-URL: #4971
Reviewed-By: Rich Trott <rtrott@gmail.com>
JungMinu added a commit that referenced this pull request Jan 31, 2016
API calls in `assert` are `deepEqual()`, not `notDeepEqual()`.
use `notDeepEqual` to make it clear.

PR-URL: #4971
Reviewed-By: Rich Trott <rtrott@gmail.com>
@JungMinu
Copy link
Member Author

Thanks, landed in de3e94b

@targos targos closed this Jan 31, 2016
@JungMinu JungMinu deleted the JungMinu-doc-api branch January 31, 2016 07:56
rvagg pushed a commit that referenced this pull request Feb 8, 2016
API calls in `assert` are `deepEqual()`, not `notDeepEqual()`.
use `notDeepEqual` to make it clear.

PR-URL: #4971
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins
Copy link
Contributor

Blocked from backporting due to other Doc fixes

MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
API calls in `assert` are `deepEqual()`, not `notDeepEqual()`.
use `notDeepEqual` to make it clear.

PR-URL: #4971
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
API calls in `assert` are `deepEqual()`, not `notDeepEqual()`.
use `notDeepEqual` to make it clear.

PR-URL: #4971
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
API calls in `assert` are `deepEqual()`, not `notDeepEqual()`.
use `notDeepEqual` to make it clear.

PR-URL: #4971
Reviewed-By: Rich Trott <rtrott@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
API calls in `assert` are `deepEqual()`, not `notDeepEqual()`.
use `notDeepEqual` to make it clear.

PR-URL: nodejs#4971
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants