tools: apply linting to doc tools #4973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
LGTM if it still works |
|
LGTM |
| @@ -517,7 +517,7 @@ bench-idle: | |||
| $(NODE) benchmark/idle_clients.js & | |||
|
|
|||
| jslint: | |||
| $(NODE) tools/eslint/bin/eslint.js src lib test tools/eslint-rules \ | |||
| $(NODE) tools/eslint/bin/eslint.js lib src test tools/doc tools/eslint-rules \ | |||
There was a problem hiding this comment.
You also need to update the corresponding line in vcbuild.bat
There was a problem hiding this comment.
Ah, yes, of course! Done! (If someone on a Windows machine can confirm that it still works on Windows, that would be great. I don't think we run lint on Windows in CI.)
|
LGTM |
And CI is green to boot. |
Apply eslint rules to `tools/doc`.
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 2, 2016
Apply eslint rules to `tools/doc`. PR-URL: nodejs#4973 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
|
Landed in 2d89d3d |
rvagg
pushed a commit
that referenced
this pull request
Feb 8, 2016
Apply eslint rules to `tools/doc`. PR-URL: #4973 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 17, 2016
Apply eslint rules to `tools/doc`. PR-URL: #4973 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
Apply eslint rules to `tools/doc`. PR-URL: #4973 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
Apply eslint rules to `tools/doc`. PR-URL: #4973 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Apply eslint rules to `tools/doc`. PR-URL: nodejs#4973 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply eslint rules to
tools/doc.