Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace forEach() with for ... of in test-accessor-properties.js #49773

Conversation

dingbx
Copy link

@dingbx dingbx commented Sep 22, 2023

Replace forEach() with for ... of in test-accessor-properties.js

Grace Hopper Day - pull request to replace forEach.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 22, 2023
@dingbx dingbx changed the title test: replace forEach with for ... of test: replace forEach() with for ... of in test-accessor-properties.js Sep 22, 2023
@tniessen tniessen added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 22, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@tniessen
Copy link
Member

@dingbx This is ready to land, however, the email address that you used for the commit is not associated with your GitHub account. We strongly recommend to either add your committer email address to your GitHub account, or to change your local committer email address to one that is already associated with your GitHub account.

@dingbx
Copy link
Author

dingbx commented Sep 28, 2023

@dingbx This is ready to land, however, the email address that you used for the commit is not associated with your GitHub account. We strongly recommend to either add your committer email address to your GitHub account, or to change your local committer email address to one that is already associated with your GitHub account.

Hi @tniessen , thanks for your reminder, I've added my commit email to my github account. The PR seems to be only mergable with authorized users. Does it mean I don't need to do anything to get it in?

@tniessen
Copy link
Member

@dingbx Thank you! Unfortunately, we cannot merge PR branches that contain merge commits since those potentially introduce non-linear commit histories. Please either remove the unnecessary merge commit from your branch or let me know if you'd like me to do so.

@RafaelGSS
Copy link
Member

We are closing it because we have not received any updates after requesting the change.

@RafaelGSS RafaelGSS closed this Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants