Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: improve internalBinding('fs') bindings #49894

Closed
wants to merge 1 commit into from
Closed

lib: improve internalBinding('fs') bindings #49894

wants to merge 1 commit into from

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Sep 27, 2023

No description provided.

@anonrig
Copy link
Member Author

anonrig commented Sep 27, 2023

cc @nodejs/fs

aduh95
aduh95 approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit rubber stampy LGTM, but LGTM nonetheless

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 28, 2023
@anonrig
Copy link
Member Author

anonrig commented Sep 28, 2023

Closing in favor of #49913

@anonrig anonrig closed this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. typings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anonrig @aduh95 @nodejs-github-bot