Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use v8::Isolate::TryGetCurrent() in DumpJavaScriptBacktrace() #50518

Closed
wants to merge 3 commits into from
Closed

src: use v8::Isolate::TryGetCurrent() in DumpJavaScriptBacktrace() #50518

wants to merge 3 commits into from

Commits on Nov 2, 2023

  1. src: use v8::Isolate::TryGetCurrent() in DumpJavaScriptBacktrace() 

    It was using Isolate::GetCurrent() which DCHECK on nullptr, even
though what we wanted was to return early if it is nullptr.
    @joyeecheung
    joyeecheung committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    cdb9c13 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. fixup! src: use v8::Isolate::TryGetCurrent() in DumpJavaScriptBacktra… 

    …ce()
    @joyeecheung
    joyeecheung committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    708664b View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2023

  1. fixup! fixup! src: use v8::Isolate::TryGetCurrent() in DumpJavaScript… 

    …Backtrace()
    @joyeecheung
    joyeecheung committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    7b506cd View commit details
    Browse the repository at this point in the history