doc: fix links order in Buffer doc #5076
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort links in lexical order
thefourtheye
added
buffer
| @@ -75,8 +75,8 @@ The character encodings currently supported by Node.js include: | |||
| Buffers are also `Uint8Array` TypedArray instances. However, there are subtle | |||
| incompatibilities with the TypedArray specification in ECMAScript 2015. For | |||
| instance, while `ArrayBuffer#slice()` creates a copy of the slice, | |||
| the implementation of [`Buffer#slice()`][] creates a view over the existing | |||
| Buffer without copying, making `Buffer#slice()` far more efficient. | |||
| the implementation of [`Buffer#slice()`][`buf.slice()`] creates a view over the | |||
There was a problem hiding this comment.
Why the reference also has backticks? :D
There was a problem hiding this comment.
Well, since it points to buf.slice() reference. I could do something like [buf-slice] and use it in both cases. But this way I guess I saved some characters ))
|
LGTM cc @nodejs/documentation |
|
LGTM |
1 similar comment
|
LGTM |
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Feb 4, 2016
Sort links in lexical order PR-URL: #5076 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in c714b2e |
rvagg
pushed a commit
that referenced
this pull request
Feb 8, 2016
Sort links in lexical order PR-URL: #5076 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Feb 9, 2016
Sort links in lexical order PR-URL: #5076 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
@estliberitas you should probably join the documentation group incase you are not aware of it. |
|
@stevemao Em, I'm not aware of this. It's not up to me as far as I recall |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 22, 2016
Sort links in lexical order PR-URL: #5076 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 22, 2016
Sort links in lexical order PR-URL: #5076 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
Sort links in lexical order PR-URL: #5076 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Sort links in lexical order PR-URL: nodejs#5076 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort links in lexical order