tools: add Node.js-specific ESLint rules #5320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add these rules: * no-restricted-modules: See http://eslint.org/docs/rules/no-restricted-modules. It has been configured to prohibit the use of the deprecated `sys` and `_linklist` modules. * no-new-require: See http://eslint.org/docs/rules/no-new-require * no-mixed-requires: http://eslint.org/docs/rules/no-mixed-requires
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 21, 2016
Add these rules: * no-restricted-modules: See http://eslint.org/docs/rules/no-restricted-modules. It has been configured to prohibit the use of the deprecated `sys` and `_linklist` modules. * no-new-require: See http://eslint.org/docs/rules/no-new-require * no-mixed-requires: http://eslint.org/docs/rules/no-mixed-requires PR-URL: nodejs#5320 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Landed in db4e752 |
rvagg
pushed a commit
that referenced
this pull request
Feb 21, 2016
Add these rules: * no-restricted-modules: See http://eslint.org/docs/rules/no-restricted-modules. It has been configured to prohibit the use of the deprecated `sys` and `_linklist` modules. * no-new-require: See http://eslint.org/docs/rules/no-new-require * no-mixed-requires: http://eslint.org/docs/rules/no-mixed-requires PR-URL: #5320 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 17, 2016
Add these rules: * no-restricted-modules: See http://eslint.org/docs/rules/no-restricted-modules. It has been configured to prohibit the use of the deprecated `sys` and `_linklist` modules. * no-new-require: See http://eslint.org/docs/rules/no-new-require * no-mixed-requires: http://eslint.org/docs/rules/no-mixed-requires PR-URL: #5320 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
Add these rules: * no-restricted-modules: See http://eslint.org/docs/rules/no-restricted-modules. It has been configured to prohibit the use of the deprecated `sys` and `_linklist` modules. * no-new-require: See http://eslint.org/docs/rules/no-new-require * no-mixed-requires: http://eslint.org/docs/rules/no-mixed-requires PR-URL: #5320 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add these rules:
http://eslint.org/docs/rules/no-restricted-modules. It has been
configured to prohibit the use of the deprecated
sysand_linklistmodules.