Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: use sccache Github action #53316

Merged
merged 2 commits into from
Jun 5, 2024
Merged

tools: use sccache Github action #53316

merged 2 commits into from
Jun 5, 2024

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Jun 3, 2024

Follow up for #52839
there is a deliberate lint error just to make this run twice for before/after comparison

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 3, 2024
@MoLow
Copy link
Member Author

MoLow commented Jun 4, 2024

build times before & after:

test-macOS: 45m 5s ⇒ 31m 14s
test-asan: 1h 32m 49s ⇒ 46m 22s
coverage-linux: 27m 31s ⇒ 28m 31s
coverage-linux-without-intl: 1h 21m 22s ⇒ 45m 1s

I have no idea why coverage-linux took 27 minutes in the original commit but in other PRs, It takes more than an hour, so I suspect it utilizes cache from the build-linux workflow introduced at #52839

@MoLow MoLow requested review from anonrig and targos June 4, 2024 06:25
targos
targos approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space usage:
node
Public
4.86 GB out of 10 GB • 103632 active caches

Knowing that the cache for the v8-update script uses almost 1GB, we still have some room.

@MoLow MoLow requested a review from benjamingr June 4, 2024 06:47
@MoLow MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 4, 2024
@anonrig
Copy link
Member

anonrig commented Jun 4, 2024

nice

panva
panva approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@panva panva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing

@MoLow MoLow added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jun 5, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 5, 2024
@nodejs-github-bot nodejs-github-bot merged commit 001c36b into nodejs:main Jun 5, 2024
26 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 001c36b

@MoLow MoLow deleted the use-sccache-on-actions branch June 6, 2024 05:34
RafaelGSS pushed a commit that referenced this pull request Jun 7, 2024
@MoLow @RafaelGSS
tools: use sccache Github action
e7f3a3c 
PR-URL: #53316
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jun 7, 2024
Merged
EliphazBouye pushed a commit to EliphazBouye/node that referenced this pull request Jun 20, 2024
@MoLow @EliphazBouye
tools: use sccache Github action
ac09366 
PR-URL: nodejs#53316
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@MoLow @bmeck
tools: use sccache Github action
22f9e11 
PR-URL: nodejs#53316
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@MoLow @marco-ippolito
tools: use sccache Github action
a960c90 
PR-URL: #53316
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@MoLow @marco-ippolito
tools: use sccache Github action
37e725a 
PR-URL: #53316
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panva panva panva approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@MoLow @nodejs-github-bot @anonrig @panva @benjamingr @lpinca @targos @VoltrexKeyva