url: group slashed protocols by protocol name #5380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, although I'm +0 about this. |
|
@benjamingr does this mean this PR would still need a +1? |
|
LGTM. Thanks for the contribution! |
Reorder slashed protocols so they are grouped by protocol name. This is done so it doesn't look like we're duplicating protocol names at the bottom of the list. PR-URL: nodejs#5380 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Evan Lucas <evanlucas@me.com>
nettofarah
force-pushed
the
reorder-protocols
branch
from
9ae35f7
to
4df108e
Compare
|
@evanlucas, @benjamingr: just reworded the commit. We should be good to go. Thank you! |
|
@evanlucas Is there anything else I need to do here? |
evanlucas
pushed a commit
that referenced
this pull request
Mar 1, 2016
Reorder slashed protocols so they are grouped by protocol name. This is done so it doesn't look like we're duplicating protocol names at the bottom of the list. PR-URL: #5380 Reviewed-By: Evan Lucas <evanlucas@me.com>
|
Landed in 610bd8d. Thanks @nettofarah!!! |
Fishrock123
pushed a commit
that referenced
this pull request
Mar 2, 2016
Reorder slashed protocols so they are grouped by protocol name. This is done so it doesn't look like we're duplicating protocol names at the bottom of the list. PR-URL: #5380 Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 17, 2016
Reorder slashed protocols so they are grouped by protocol name. This is done so it doesn't look like we're duplicating protocol names at the bottom of the list. PR-URL: #5380 Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
Reorder slashed protocols so they are grouped by protocol name. This is done so it doesn't look like we're duplicating protocol names at the bottom of the list. PR-URL: #5380 Reviewed-By: Evan Lucas <evanlucas@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorder slashed protocols so they are grouped by protocol name.
This is done so it doesn't look like we're duplicating protocol names at the
bottom of the list.