Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v22.5.1 proposal #53935

Merged
merged 2 commits into from
Jul 19, 2024
Merged

v22.5.1 proposal #53935

merged 2 commits into from
Jul 19, 2024

Conversation

richardlau
Copy link
Member

2024-07-19, Version 22.5.1 (Current), @richardlau

Notable Changes

This release fixes a regression introduced in Node.js 22.5.0. The problem is known to display the following symptoms:

  • Crash with FATAL ERROR: v8::Object::GetCreationContextChecked No creation context available #53902
  • npm errors with npm error Exit handler never called! npm/cli#7657
  • yarn hangs or outputs Usage Error: Couldn't find the node_modules state file - running an install might help (findPackageLocation) yarnpkg/berry#6398

Commits


cc @nodejs/releasers

RedYetiDev and others added 2 commits July 19, 2024 00:48
This reverts commit ed6f45b.

PR-URL: #53904
Refs: yarnpkg/berry#6398
Refs: npm/cli#7657
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Notable changes:

This release fixes a regression introduced in Node.js 22.5.0. The
problem is known to display the following symptoms:

- Crash with
```
FATAL ERROR: v8::Object::GetCreationContextChecked No creation context available
```

- npm errors with `npm error Exit handler never called!`

- yarn hangs or outputs
```
Usage Error: Couldn't find the node_modules state file - running an install might help (findPackageLocation)
```

PR-URL: #53935
Refs: #53902
Refs: npm/cli#7657
Refs: yarnpkg/berry#6398
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Jul 19, 2024
@richardlau richardlau added request-ci Add this label to start a Jenkins CI on a PR. and removed c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Jul 19, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 19, 2024
@nodejs-github-bot

This comment was marked as outdated.

@RedYetiDev RedYetiDev added release Issues and PRs related to Node.js releases. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Jul 19, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 19, 2024

@merceyz
Copy link
Member

merceyz commented Jul 19, 2024

yarn hangs or outputs Usage Error: Couldn't find the node_modules state file - running an install might help (findPackageLocation) yarnpkg/berry#6398

The Yarn symptom is that it either hangs or if not in interactive mode (CI=true) terminates mid install with exit code 0 (empty event loop) which causes commands run after that to complain that a install hasn't been done.

@richardlau
Copy link
Member Author

yarn hangs or outputs Usage Error: Couldn't find the node_modules state file - running an install might help (findPackageLocation) yarnpkg/berry#6398

The Yarn symptom is that it either hangs or if not in interactive mode (CI=true) terminates mid install with exit code 0 (empty event loop) which causes commands run after that to complain that a install hasn't been done.

ah thanks. If I update the wording I'm going to have to rerun the builds. I'm doing some final checks -- if anything comes up and the build needs to change I'll reword otherwise I think we can release as-is and reword afterwards in follow up PRs to the changelog if necessary.

@richardlau
Copy link
Member Author

CITGM: https://ci.nodejs.org/job/citgm-smoker/3461/

For some reason, the CITGM job installed citgm@8.1.0 instead of the latest citgm@9.2.2. It wasn't just this job -- the previous jobs appear to have done the same. Some of the failing modules are ones that have been removed from the lookup since 8.1.0 (e.g. bluebird).
e.g. https://ci.nodejs.org/job/citgm-smoker/3461/nodes=ubuntu2204-64/consoleFull

03:06:31 npm verbose title npm install citgm
03:06:31 npm verbose argv "install" "--prefix" "/home/iojs/build/workspace/citgm-smoker/smoker" "--global" "--loglevel" "silly" "citgm"
03:06:31 npm verbose logfile logs-max:10 dir:/home/iojs/build/workspace/citgm-smoker/npm_cache/_logs/2024-07-19T02_06_31_144Z-
03:06:31 npm verbose logfile /home/iojs/build/workspace/citgm-smoker/npm_cache/_logs/2024-07-19T02_06_31_144Z-debug-0.log
03:06:31 npm silly packumentCache heap:2090074112 maxSize:522518528 maxEntrySize:261259264
03:06:31 npm silly logfile start cleaning logs, removing 2 files
03:06:31 npm silly idealTree buildDeps
03:06:31 npm silly fetch manifest citgm@*
03:06:31 npm silly packumentCache full:https://registry.npmjs.org/citgm cache-miss
03:06:31 npm silly logfile done cleaning log files
03:06:31 npm http fetch GET 200 https://registry.npmjs.org/citgm 200ms (cache revalidated)
03:06:31 npm silly packumentCache full:https://registry.npmjs.org/citgm set size:879187 disposed:false
03:06:31 npm silly placeDep ROOT citgm@8.1.0 OK for:  want: *

richardlau added a commit that referenced this pull request Jul 19, 2024
@richardlau richardlau merged commit fd9233a into v22.x Jul 19, 2024
72 checks passed
@richardlau richardlau deleted the v22.5.1-proposal branch July 19, 2024 13:39
richardlau added a commit that referenced this pull request Jul 19, 2024
Notable changes:

This release fixes a regression introduced in Node.js 22.5.0. The
problem is known to display the following symptoms:

- Crash with
```
FATAL ERROR: v8::Object::GetCreationContextChecked No creation context available
```

- npm errors with `npm error Exit handler never called!`

- yarn hangs or outputs
```
Usage Error: Couldn't find the node_modules state file - running an install might help (findPackageLocation)
```

PR-URL: #53935
Refs: #53902
Refs: npm/cli#7657
Refs: yarnpkg/berry#6398
richardlau added a commit to richardlau/nodejs.org that referenced this pull request Jul 19, 2024
github-merge-queue bot pushed a commit to nodejs/nodejs.org that referenced this pull request Jul 19, 2024
mcmire added a commit to MetaMask/eth-json-rpc-middleware that referenced this pull request Jul 19, 2024
There seems to be a regression in Node 22.5.0 which [prevents `yarn
install` from running][1] and in turns prevents CI from completing
successfully. This regression was [fixed in 22.5.1][2], so this commit
ensures that CI is using this version.

[1]: yarnpkg/berry#6398
[2]: nodejs/node#53935
mcmire added a commit to MetaMask/eth-json-rpc-middleware that referenced this pull request Jul 19, 2024
There seems to be a regression in Node 22.5.0 which [prevents `yarn
install` from running][1] and in turns prevents CI from completing
successfully. This regression was [fixed in 22.5.1][2]. We are using
`22.x` in CI, so in theory it should be using this version, but that
does not seem be the case right now. So this commit ensures that CI is
using this version by naming it explicitly.

[1]: yarnpkg/berry#6398
[2]: nodejs/node#53935
mcmire added a commit to MetaMask/eth-json-rpc-middleware that referenced this pull request Jul 19, 2024
There seems to be a regression in Node 22.5.0 which [prevents `yarn
install` from running][1] and in turns prevents CI from completing
successfully. This regression was [fixed in 22.5.1][2]. We are using
`22.x` in CI, so in theory it should be using this version, but that
does not seem be the case right now. So this commit ensures that CI is
using this version by naming it explicitly.

[1]: yarnpkg/berry#6398
[2]: nodejs/node#53935
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants