Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove flaky designation from fixed tests #5459

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 26, 2016

test-tls-ticket-cluster and test-vm-syntax-error-stderr are no
longer flaky.

Refs: #2510
Refs: #2660

`test-tls-ticket-cluster` and `test-vm-syntax-error-stderr` are no
longer flaky.

Refs: nodejs#2510
Refs: nodejs#2660
@Trott Trott added test Issues and PRs related to the tests. lts-watch-v4.x labels Feb 26, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Feb 26, 2016

LGTM

@Trott
Copy link
Member Author

Trott commented Feb 29, 2016

Trott added a commit to Trott/io.js that referenced this pull request Feb 29, 2016
`test-tls-ticket-cluster` and `test-vm-syntax-error-stderr` are no
longer flaky.

Refs: nodejs#2510
Refs: nodejs#2660
PR-URL: nodejs#5459
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott
Copy link
Member Author

Trott commented Feb 29, 2016

Landed in 4d6b4c3

@Trott Trott closed this Feb 29, 2016
@Fishrock123 Fishrock123 mentioned this pull request Mar 1, 2016
5 tasks
Fishrock123 pushed a commit that referenced this pull request Mar 2, 2016
`test-tls-ticket-cluster` and `test-vm-syntax-error-stderr` are no
longer flaky.

Refs: #2510
Refs: #2660
PR-URL: #5459
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
`test-tls-ticket-cluster` and `test-vm-syntax-error-stderr` are no
longer flaky.

Refs: #2510
Refs: #2660
PR-URL: #5459
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
`test-tls-ticket-cluster` and `test-vm-syntax-error-stderr` are no
longer flaky.

Refs: #2510
Refs: #2660
PR-URL: #5459
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott Trott deleted the unmark-flakies branch January 13, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants