Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: apply Linux workaround to Linux only #5471

Closed
wants to merge 1 commit into from
Closed

test: apply Linux workaround to Linux only #5471

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 28, 2016

Do not try Ubuntu/SUSE/Debian-specific hostnames for IPv6 localhost
unless we are on Linux.

Fixes: #4546

@Trott
test: apply Linux workaround to Linux only
644f9aa 
Do not try Ubuntu/SUSE/Debian-specific hostnames for IPv6 localhost
unless we are on Linux.

Fixes: nodejs#4546
@Trott Trott added the test Issues and PRs related to the tests. label Feb 28, 2016
@Trott Trott mentioned this pull request Feb 28, 2016
Closed
@bnoordhuis
Copy link
Member

LGTM. The list is used in only one test, by the way.

@evanlucas
Copy link
Contributor

LGTM

@Fishrock123
Copy link
Contributor

Fixes it for me, thanks! LGTM

@Trott
Copy link
Member Author

Trott commented Mar 1, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/1800/

Trott added a commit to Trott/io.js that referenced this pull request Mar 1, 2016
@Trott
test: apply Linux workaround to Linux only
ad36ea5 
Do not try Ubuntu/SUSE/Debian-specific hostnames for IPv6 localhost
unless we are on Linux.

Fixes: nodejs#4546
PR-URL: nodejs#5471
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Trott
Copy link
Member Author

Trott commented Mar 1, 2016

Landed in ad36ea5

@Trott Trott closed this Mar 1, 2016
Fishrock123 pushed a commit that referenced this pull request Mar 2, 2016
@Trott @Fishrock123
test: apply Linux workaround to Linux only
81348e8 
Do not try Ubuntu/SUSE/Debian-specific hostnames for IPv6 localhost
unless we are on Linux.

Fixes: #4546
PR-URL: #5471
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
@Trott
test: apply Linux workaround to Linux only
324c721 
Do not try Ubuntu/SUSE/Debian-specific hostnames for IPv6 localhost
unless we are on Linux.

Fixes: #4546
PR-URL: #5471
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
@Trott
test: apply Linux workaround to Linux only
ba7a247 
Do not try Ubuntu/SUSE/Debian-specific hostnames for IPv6 localhost
unless we are on Linux.

Fixes: #4546
PR-URL: #5471
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
@Trott
test: apply Linux workaround to Linux only
ba9ad26 
Do not try Ubuntu/SUSE/Debian-specific hostnames for IPv6 localhost
unless we are on Linux.

Fixes: #4546
PR-URL: #5471
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Trott Trott deleted the fix-for-fishrock branch January 13, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @bnoordhuis @evanlucas @Fishrock123 @jasnell @MylesBorins