tools: reduce verbosity of cpplint #5578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every time `make test` is run, the cpplint prints the file it successfully linted. None of the other linters in the project does that. This patch simply removes the "Done processing" message from the cpplint.
|
The effect of this change can be seen by comparing the output of test-linter with this change and the output of test-linter without this change |
|
LGTM |
3 similar comments
|
LGTM |
|
LGTM |
|
LGTM |
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2016
Every time `make test` is run, the cpplint prints the file it successfully linted. None of the other linters in the project does that. This patch simply removes the "Done processing" message from the cpplint. PR-URL: #5578 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 3eff42b |
Merged
Fishrock123
pushed a commit
that referenced
this pull request
Mar 8, 2016
Every time `make test` is run, the cpplint prints the file it successfully linted. None of the other linters in the project does that. This patch simply removes the "Done processing" message from the cpplint. PR-URL: #5578 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Mar 8, 2016
Every time `make test` is run, the cpplint prints the file it successfully linted. None of the other linters in the project does that. This patch simply removes the "Done processing" message from the cpplint. PR-URL: #5578 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 17, 2016
Every time `make test` is run, the cpplint prints the file it successfully linted. None of the other linters in the project does that. This patch simply removes the "Done processing" message from the cpplint. PR-URL: #5578 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
Every time `make test` is run, the cpplint prints the file it successfully linted. None of the other linters in the project does that. This patch simply removes the "Done processing" message from the cpplint. PR-URL: #5578 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
Every time `make test` is run, the cpplint prints the file it successfully linted. None of the other linters in the project does that. This patch simply removes the "Done processing" message from the cpplint. PR-URL: #5578 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
tools
Description of change
Every time
make testis run, the cpplint prints the file itsuccessfully linted. None of the other linters in the project does
that. This patch simply removes the "Done processing" message from the
cpplint.