Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: fix v8 armv6 run-time detection #559

Merged
merged 3 commits into from
Jan 22, 2015
Merged

deps: fix v8 armv6 run-time detection #559

merged 3 commits into from
Jan 22, 2015

Commits on Jan 22, 2015

  1. deps: fix v8 armv6 run-time detection 

    The elf_platform suffix in /proc/cpuinfo moved to the model name field
in Linux 3.8.

Out-of-tree patch pending https://codereview.chromium.org/867713003/

Fixes: nodejs#283
PR-URL: nodejs#559
Reviewed-By: Fedor Indutny <fedor@indutny.com>
    @bnoordhuis
    bnoordhuis committed Jan 22, 2015
    Configuration menu
    Copy the full SHA
    297cadb View commit details
    Browse the repository at this point in the history

  2. configure: disable vfpv3 on armv6 

    VFPv3 is ARMv7-only, enabling it for ARMv6 is therefore always wrong.
Mea culpa, I do believe I'm the original author of that change.

Fixes: nodejs#283
PR-URL: nodejs#559
Reviewed-By: Fedor Indutny <fedor@indutny.com>
    @bnoordhuis
    bnoordhuis committed Jan 22, 2015
    Configuration menu
    Copy the full SHA
    7d9d756 View commit details
    Browse the repository at this point in the history

  3. configure: remove unused arm_neon variable 

    Remove the configure check, the flag was dropped in V8 3.28.

PR-URL: nodejs#559
Reviewed-By: Fedor Indutny <fedor@indutny.com>
    @bnoordhuis
    bnoordhuis committed Jan 22, 2015
    Configuration menu
    Copy the full SHA
    c6cd460 View commit details
    Browse the repository at this point in the history