Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix offending max-len linter error #5980

Closed
wants to merge 1 commit into from
Closed

test: fix offending max-len linter error #5980

wants to merge 1 commit into from

Conversation

thefourtheye
Copy link
Contributor

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?

Affected core subsystem(s)

test

Description of change

fix offending max-len linter error

@thefourtheye thefourtheye added the test Issues and PRs related to the tests. label Mar 31, 2016
@thefourtheye thefourtheye mentioned this pull request Mar 31, 2016
Merged
2 tasks
@Fishrock123
Copy link
Contributor

lgtm

@Fishrock123
Copy link
Contributor

Refs: #5935

@thefourtheye
test: fix offending max-len linter error
d024316 
Refer: nodejs#5935
PR-URL: nodejs#5980
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@thefourtheye
Copy link
Contributor Author

CI Run: https://ci.nodejs.org/job/node-test-pull-request/2114/

@phillipj
Copy link
Member

LGTM

@thefourtheye
Copy link
Contributor Author

Linter passes https://ci.nodejs.org/job/node-test-linter/1875/. Landing this, as this is a trivial change and much necessary one for all the builds.

@thefourtheye
Copy link
Contributor Author

Landed in 854f758

thefourtheye added a commit that referenced this pull request Mar 31, 2016
@thefourtheye
test: fix offending max-len linter error
854f758 
Refer: #5935
PR-URL: #5980
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Phillip Johnsen <johphi@gmail.com>
@thefourtheye thefourtheye deleted the fix-lint-stdin branch March 31, 2016 21:19
MylesBorins pushed a commit that referenced this pull request Apr 5, 2016
@thefourtheye
test: fix offending max-len linter error
4f1fa2a 
Refer: #5935
PR-URL: #5980
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Phillip Johnsen <johphi@gmail.com>
This was referenced Apr 5, 2016
Closed
Merged
MylesBorins pushed a commit that referenced this pull request Apr 11, 2016
@thefourtheye
test: fix offending max-len linter error
10fe79b 
Refer: #5935
PR-URL: #5980
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Phillip Johnsen <johphi@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 11, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thefourtheye @Fishrock123 @phillipj @jasnell @MylesBorins