Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make arch available in status files #5997

Closed
wants to merge 1 commit into from

Conversation

santigimeno
Copy link
Member

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?

Affected core subsystem(s)

test

Description of change

The value is retrieved from process.arch in node itself.

Thanks to @joaocgreis for providing a similar implementation (mostly equal)

/cc @Trott

The value is retrieved from `process.arch` in node itself.
@Trott
Copy link
Member

Trott commented Apr 1, 2016

@nodejs/build

@Trott Trott added test Issues and PRs related to the tests. build Issues and PRs related to build files or the CI. lts-watch-v4.x labels Apr 1, 2016
@Trott
Copy link
Member

Trott commented Apr 1, 2016

@joaocgreis
Copy link
Member

LGTM

cc @nodejs/testing

@jasnell
Copy link
Member

jasnell commented Apr 1, 2016

LGTM

1 similar comment
@jbergstroem
Copy link
Member

LGTM

jasnell pushed a commit that referenced this pull request Apr 4, 2016
The value is retrieved from `process.arch` in node itself.

PR-URL: #5997
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@jasnell
Copy link
Member

jasnell commented Apr 4, 2016

Landed in 858b4b3

@jasnell jasnell closed this Apr 4, 2016
MylesBorins pushed a commit that referenced this pull request Apr 5, 2016
The value is retrieved from `process.arch` in node itself.

PR-URL: #5997
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
This was referenced Apr 5, 2016
MylesBorins pushed a commit that referenced this pull request Apr 11, 2016
The value is retrieved from `process.arch` in node itself.

PR-URL: #5997
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@MylesBorins MylesBorins mentioned this pull request Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants