Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-http-client-abort #6124

Closed
wants to merge 1 commit into from
Closed

test: fix flaky test-http-client-abort #6124

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 8, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test http arm

Description of change

Fixes: #6080

@Trott Trott added http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. arm Issues and PRs related to the ARM platform. labels Apr 8, 2016
@Trott
Copy link
Member Author

Trott commented Apr 8, 2016

Stress test showing this version of the test is not flaky on pi2-raspbian-wheezy: https://ci.nodejs.org/job/node-stress-single-test/586/nodes=pi2-raspbian-wheezy/console

@Trott Trott mentioned this pull request Apr 8, 2016
Closed
@santigimeno
Copy link
Member

LGTM

1 similar comment
@cjihrig
Copy link
Contributor

cjihrig commented Apr 8, 2016

LGTM

@Trott
Copy link
Member Author

Trott commented Apr 8, 2016

Stress test showing the version of this test that is on master is flaky:
https://ci.nodejs.org/job/node-stress-single-test/587/nodes=pi2-raspbian-wheezy/console

@Trott
Copy link
Member Author

Trott commented Apr 8, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/2223/

@mscdex
Copy link
Contributor

mscdex commented Apr 8, 2016

Only 999 runs? ;-)

LGTM though

@jasnell
Copy link
Member

jasnell commented Apr 9, 2016

LGTM

jasnell pushed a commit that referenced this pull request Apr 9, 2016
@Trott @jasnell
test: fix flaky test-http-client-abort
a9aa199 
Fixes: #6080
PR-URL: #6124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Apr 9, 2016

Landed in a9aa199

@jasnell jasnell closed this Apr 9, 2016
MylesBorins pushed a commit that referenced this pull request Apr 19, 2016
@Trott
test: fix flaky test-http-client-abort
d6f26a3 
Fixes: #6080
PR-URL: #6124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@Trott
test: fix flaky test-http-client-abort
251fc03 
Fixes: #6080
PR-URL: #6124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 20, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@Trott
test: fix flaky test-http-client-abort
476535c 
Fixes: #6080
PR-URL: #6124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Apr 21, 2016
Closed
Closed
jasnell pushed a commit that referenced this pull request Apr 26, 2016
@Trott @jasnell
test: fix flaky test-http-client-abort
7ce9670 
Fixes: #6080
PR-URL: #6124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 17, 2016
@Trott
test: fix flaky test-http-client-abort
eae2f86 
Fixes: #6080
PR-URL: #6124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
@Trott
test: fix flaky test-http-client-abort
a865975 
Fixes: #6080
PR-URL: #6124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 18, 2016
Merged
@Trott Trott deleted the fewer branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate flaky test test-http-client-abort.js
6 participants
@Trott @santigimeno @cjihrig @mscdex @jasnell @MylesBorins