Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: Check typed array view type in deepEqual (backport to 4.x) #6147

Closed
wants to merge 1 commit into from
Closed

assert: Check typed array view type in deepEqual (backport to 4.x) #6147

wants to merge 1 commit into from

Commits on Apr 11, 2016

  1. assert: Check typed array view type in deepEqual 

    Do not convert typed arrays to `Buffer` for deepEqual since
their values may not be accurately represented by 8-bit ints.
Instead perform binary comparison of underlying `ArrayBuffer`s,
but only when the array types match.

Never apply any kind of optimization for floating-point typed
arrays since bit pattern equality is not the right kind of check
for them.

PR-URL: nodejs#5910
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Fixes: nodejs#5907
    @addaleax
    addaleax committed Apr 11, 2016
    Configuration menu
    Copy the full SHA
    d06adf9 View commit details
    Browse the repository at this point in the history