Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: native module reloading is not supported #6168

Closed
wants to merge 1 commit into from
Closed

doc: native module reloading is not supported #6168

wants to merge 1 commit into from

Conversation

bengl
Copy link
Member

@bengl bengl commented Apr 12, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Clarify in docs for require.cache that reloading native modules
isn't supported.

Close this if #6165 lands instead.

Related: #6160

@bengl
doc: native module reloading is not supported
b6d97db 
Clarify in docs for require.cache that reloading native modules
isn't supported.

Related: nodejs#6160
@benjamingr
Copy link
Member

LGTM

@benjamingr benjamingr added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Apr 12, 2016
@mscdex
Copy link
Contributor

mscdex commented Apr 12, 2016

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Apr 18, 2016

LGTM

jasnell pushed a commit that referenced this pull request Apr 18, 2016
@bengl @jasnell
doc: native module reloading is not supported
5c14d69 
Clarify in docs for require.cache that reloading native modules
isn't supported.

Related: #6160
PR-URL: #6168
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Apr 18, 2016

Landed in 5c14d69

@jasnell jasnell closed this Apr 18, 2016
MylesBorins pushed a commit that referenced this pull request Apr 19, 2016
@bengl
doc: native module reloading is not supported
c587d3c 
Clarify in docs for require.cache that reloading native modules
isn't supported.

Related: #6160
PR-URL: #6168
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@bengl
doc: native module reloading is not supported
bd5f48d 
Clarify in docs for require.cache that reloading native modules
isn't supported.

Related: #6160
PR-URL: #6168
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@bengl
doc: native module reloading is not supported
b22ab38 
Clarify in docs for require.cache that reloading native modules
isn't supported.

Related: #6160
PR-URL: #6168
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 20, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@bengl
doc: native module reloading is not supported
3f73502 
Clarify in docs for require.cache that reloading native modules
isn't supported.

Related: #6160
PR-URL: #6168
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Apr 21, 2016
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
@bengl @MylesBorins
doc: native module reloading is not supported
90eb765 
Clarify in docs for require.cache that reloading native modules
isn't supported.

Related: #6160
PR-URL: #6168
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request Apr 25, 2016
@bengl @joelostrowski
doc: native module reloading is not supported
8e3182d 
Clarify in docs for require.cache that reloading native modules
isn't supported.

Related: nodejs#6160
PR-URL: nodejs#6168
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
@bengl @jasnell
doc: native module reloading is not supported
5d6cf11 
Clarify in docs for require.cache that reloading native modules
isn't supported.

Related: #6160
PR-URL: #6168
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 3, 2016
@bengl
doc: native module reloading is not supported
862a63f 
Clarify in docs for require.cache that reloading native modules
isn't supported.

Related: #6160
PR-URL: #6168
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 6, 2016
@bengl
doc: native module reloading is not supported
7a03945 
Clarify in docs for require.cache that reloading native modules
isn't supported.

Related: #6160
PR-URL: #6168
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
@bengl
doc: native module reloading is not supported
df5ce6f 
Clarify in docs for require.cache that reloading native modules
isn't supported.

Related: #6160
PR-URL: #6168
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 18, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bengl @benjamingr @mscdex @jasnell @MylesBorins