Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose v6.1.0 (Openssl update) #6557

Merged
merged 61 commits into from
May 5, 2016
Merged

Propose v6.1.0 (Openssl update) #6557

merged 61 commits into from
May 5, 2016

Commits on May 4, 2016

  1. net: introduce Socket#connecting property

    There is no official way to figure out if the socket that you have on
    hand is still connecting to the remote host. Introduce
    `Socket#connecting`, which is essentially an unprefixed `_connecting`
    property that we already had.
    
    PR-URL: #6404
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    indutny authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    cbbe95e View commit details
    Browse the repository at this point in the history
  2. doc: use Buffer.from() instead of new Buffer()

    Use new API of Buffer to developers in most documents.
    
    PR-URL: #6367
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    JacksonTian authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    19fb134 View commit details
    Browse the repository at this point in the history
  3. doc: correctly document the behavior of ee.once().

    Addresses #5566. The `ee.once()` function is currently documented as
    invoking the listener, and then removing it when the event is
    triggered. However, this is not really the case. The listener is removed
    and _then_ invoked. This only matters in a narrow set of use cases, but
    when it matters, it matters that the docs are correct.
    
    See the issue (#5566) for a discussion on why the code has not been
    modified to match the documentation, but instead the documentation has
    been modified to match the code.
    
    Fixes: #5566
    PR-URL: #6371
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    lance authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    36207c6 View commit details
    Browse the repository at this point in the history
  4. build: don't compile with -B

    Turn off the custom toolchain, we don't bundle ld.gold.  It's not that
    useful anyway because it uses a fixed path.  For people that do use a
    custom toolchain, there is the GCC_EXEC_PREFIX environment variable.
    
    PR-URL: #6393
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    bnoordhuis authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    11e7cc5 View commit details
    Browse the repository at this point in the history
  5. benchmark: Fix crash in net benchmarks

    Net benchmarks create partial event emitters that do not have all of the
    required event emitter functions. They currently mock out `on`, `once`,
    and `emit` functions. This change mocks out `prependListener` as well to
    avoid crashing in `_stream_readable`.
    
    PR-URL: https://github.com/nodejs/node/pull/6407
    Fixes: https://github.com/nodejs/node/issues/6405
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
    Reviewed-By: Matthew Loring <mattloring@google.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Matt Loring authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    7b9ae70 View commit details
    Browse the repository at this point in the history
  6. build: exclude tap files from tarballs

    PR-URL: #6348
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    mscdex authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    8956432 View commit details
    Browse the repository at this point in the history
  7. doc: update build instructions for OS X

    Building Node.js on OS X requires XCode (because node-gyp requires
    XCode). Add that information to BUILDING.md.
    
    Additionally, this changes references to `Macintosh` in BUILDING.md to
    refer to `OS X`. This is consistent with the way other references are to
    operating system families (`Unix`, `Windows`) and not brand names or
    hardware architectures.
    
    PR-URL: #6309
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Trott authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    f6d7279 View commit details
    Browse the repository at this point in the history
  8. crypto: fix error in deprecation message

    The deprecation message for `crypto.Credentials` says to use
    `tls.createSecureContext` but the correct property to use is
    `tls.SecureContext()`.
    
    Fix the deprecation message and add a test that checks the mappings of
    deprecated properties and their warning messages.
    
    PR-URL: #6344
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    fdde369 View commit details
    Browse the repository at this point in the history
  9. test,tools: adjust function argument alignment

    In preparation for a lint rule enforcing function argument alignment,
    adjust function arguments to be aligned.
    
    PR-URL: #6390
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: Imran Iqbal <imran@imraniqbal.org>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
    Trott authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    6d1606e View commit details
    Browse the repository at this point in the history
  10. tools: lint for function argument alignment

    In function calls that span multiple lines, apply a custom lint rule to
    enforce argument alignment.
    
    With this rule, the following code will be flagged as an error by the
    linter because the arguments on the second line start in a different
    column than on the first line:
    
        myFunction(a, b,
          c, d);
    
    The following code will not be flagged as an error by the linter:
    
        myFunction(a, b,
                   c, d);
    
    PR-URL: #6390
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: Imran Iqbal <imran@imraniqbal.org>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
    Trott authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    3f608b1 View commit details
    Browse the repository at this point in the history
  11. tools: add tests for the doctool

    * Test the toHTML function in html.js. Check that given valid markdown
      it produces the expected html. One test case will prevent regressions
      of #5873.
    * Check that when given valid markdown toJSON produces valid JSON with
      the expected schema.
    * Add doctool to the list of built in tests so it runs in CI.
    
    PR-URL: #6031
    Fixes: #5955
    Reviewed-By: Roman Reiss <me@silverwind.io>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    iankronquist authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    66903f6 View commit details
    Browse the repository at this point in the history
  12. test,tools: limit lint tolerance of gc global

    Lint rules permitted the `gc` global in any test file. This change
    limits it to just the files that need it.
    
    PR-URL: #6324
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Trott authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    089362f View commit details
    Browse the repository at this point in the history
  13. build: unbreak -prof, disable PIE on OS X

    Commit 204f3a8 ("build: Bump MACOSX_DEPLOYMENT_TARGET to 10.7")
    unwittingly turned on new ASLR features that make `-prof` unusable for
    profiling C++ code, breaking `test/parallel/test-tick-processor.js` in
    the process.  Build with `-Wl,-no_pie` for now.
    
    Fixes: #5903
    PR-URL: #6453
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    bnoordhuis authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    7153f96 View commit details
    Browse the repository at this point in the history
  14. tools: remove default parameters from lint rule

    The CI server uses system Node.js for linting, which is currently v5.x.
    So default parameters are not supported there. This change removes the
    default parameters.
    
    PR-URL: #6411
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    e62c42b View commit details
    Browse the repository at this point in the history
  15. src: unify implementations of Utf8Value etc.

    Unify the common code of `Utf8Value`, `TwoByteValue`, `BufferValue`
    and `StringBytes::InlineDecoder` into one class. Always make the
    result zero-terminated for the first three.
    
    This fixes two problems in passing:
    
    * When the conversion of the input value to String fails,
      make the buffer zero-terminated anyway. Previously, this would
      have resulted in possibly reading uninitialized data in multiple
      places in the code. An instance of that problem can be reproduced
      by running e.g.
      `valgrind node -e 'net.isIP({ toString() { throw Error() } })'`.
    * Previously, `BufferValue` copied one byte too much from the source,
      possibly resulting in an out-of-bounds memory access.
      This can be reproduced by running e.g.
      `valgrind node -e \
        'fs.openSync(Buffer.from("node".repeat(8192)), "r")'`.
    
    Further minor changes:
    * This lifts the `out()` method of `StringBytes::InlineDecoder`
      to the common class so that it can be used when using the
      overloaded `operator*` does not seem appropiate.
    * Hopefully clearer variable names.
    * Add checks to make sure the length of the data does not exceed
      the allocated storage size, including the possible null terminator.
    
    PR-URL: #6357
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    addaleax authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    fa9d82d View commit details
    Browse the repository at this point in the history
  16. doc: better example & synopsis

    PR-URL: #6167
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com>
    Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    ab84d69 View commit details
    Browse the repository at this point in the history
  17. doc: no Node.js(1)

    Node.js(1) does not make sense.
    Node(1) would, but this isn’t a `man` page.
    
    PR-URL: #6167
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com>
    Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    150dd36 View commit details
    Browse the repository at this point in the history
  18. doc: subdivide TOC, add auxiliary links

    PR-URL: #6167
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com>
    Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    fc0fbf1 View commit details
    Browse the repository at this point in the history
  19. tools: fix exit code when linting from CI

    Before this, if there were lint errors reported by `make jslint-ci`,
    the process would still exit with an exit code of zero.
    
    This commit fixes that to align with `make jslint` (exit with
    non-zero on lint errors).
    
    PR-URL: #6412
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Reviewed-By: Phillip Johnsen <johphi@gmail.com>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    mscdex authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    9f23cb2 View commit details
    Browse the repository at this point in the history
  20. events: pass the original listener added by once

    When removing a `once` listener, the listener being passed to
    the `removeListener` callback is the wrapper. This unwraps the
    listener so that `removeListener` is passed the actual listener.
    
    PR-URL: #6394
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    DavidCai1111 authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    2c92a1f View commit details
    Browse the repository at this point in the history
  21. process: add process.cpuUsage() - implementation, doc, tests

    Add process.cpuUsage() method that returns the user and system
    CPU time usage of the current process
    
    PR-URL: #6157
    Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Patrick Mueller authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    1b9fdba View commit details
    Browse the repository at this point in the history
  22. doc: expand documentation for process.exit()

    The fact that process.exit() interrupts pending async operations
    such as non-blocking i/o is becoming a bit more pronounced with
    the recent libuv update. This commit expands the documentation
    for `process.exit()` to explain clearly how it affects async
    operations.
    
    PR-URL: #6410
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
    jasnell authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    b3f75ec View commit details
    Browse the repository at this point in the history
  23. assert: allow circular references

    assert.deepEqual() and assert.deepStrictEqual() will no longer throw a
    RangeError if passed objects with circular references.
    
    PR-URL: #6432
    Fixes: #6416
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Trott authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    76c9ab5 View commit details
    Browse the repository at this point in the history
  24. doc: added note warning about change to console.endTime()

    Unintended functionality was removed from console.endTime by
    #3562. Prior to that, you could
    call console.endTime multiple times for the same label.
    
    PR-URL: #6454
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>
    ben-page authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    fd37d54 View commit details
    Browse the repository at this point in the history
  25. doc: Remove extra space in REPL example

    PR-URL: #6447
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Juan authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    8eb87ee View commit details
    Browse the repository at this point in the history
  26. doc: fix incorrect syntax in examples

    The cluster docs had a period instead of a semicolon at the end of two
    lines.
    
    PR-URL: #6463
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: Jackson Tian <shvyo1987@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    evanlucas authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    bfcde97 View commit details
    Browse the repository at this point in the history
  27. doc: fix EventEmitter#eventNames() example

    Replace myErr with myEE in one place.
    Fix the expected output to have the actual formatting.
    
    PR-URL: #6417
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    ChALkeR authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    4068d64 View commit details
    Browse the repository at this point in the history
  28. build: use shorthand lint target from test

    Instead of invoking jslint/cpplint from the test target,
    call on the generic lint instead since it checks if eslint
    exists. Since our tarballs lacks eslint we now get a more graceful
    exit from `make test` instead of a traceback from jslint.
    
    PR-URL: #6406
    Fixes: #6408
    Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    jbergstroem authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    0d19853 View commit details
    Browse the repository at this point in the history
  29. doc: make writable.setDefaultEncoding() return this

    Let this function return `this` for parity with `readable.setEncoding()`.
    
    PR-URL: #5040
    Fixes: #5013
    
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Calvin Metcalf <calvin.metcalf@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    estliberitas authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    e6c8da4 View commit details
    Browse the repository at this point in the history
  30. doc: remove all scrollbar styling

    Returns the doc custom scrollbar to native style.
    
    Fixes: #6443
    PR-URL: #6479
    Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    claudiorodriguez authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    4ae39f9 View commit details
    Browse the repository at this point in the history
  31. doc: use Node.js in synopsis document

    Change an instance of `Node` in the synopsis document to `Node.js.`
    
    PR-URL: #6476
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Trott authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    7034ebe View commit details
    Browse the repository at this point in the history
  32. doc: clarifies http.serverResponse implementation

    Since http.serverResponse does not inherit from Stream.writable
    it does not pass the test `serverResponse instanceof stream.Writable`.
    This commit clarifies that serverResponse does not inherit from
    stream.Writable and therefore should not be expected to pass the above
    test
    
    Fixes: #6046
    PR-URL: #6072
    Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
    Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    AllenSH12 authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    3d5b732 View commit details
    Browse the repository at this point in the history
  33. doc: extra clarification of historySize option

    History caching in the `readline` io is active only for terminal
    interaction. Appropriate variables are initialized and relevant
    `_addHistory()` function is called only if exposed `terminal` option
    of `readline.createInterface()` is set `true` by user or internal
    output check.
    
    This clarification is useful to assure users there will be now wasted
    overhead connected with history caching if `readline` is used not
    for terminal interaction (e.g. for reading files line by line).
    
    Particularly this fix is helpful after #6352 landing.
    
    PR-URL: #6397
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    vsemozhetbyt authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    13e6608 View commit details
    Browse the repository at this point in the history
  34. doc: fix fs.realpath man pg links

    There is no realpath(2), only in sections 1 & 3
    causes broken link on nodejs.org/api/ docs
    
    PR-URL: #6451
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    phette23 authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    ab7055b View commit details
    Browse the repository at this point in the history
  35. doc: fix a typo in __dirname section

    PR-URL: #6473
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
    toyota790 authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    969f96a View commit details
    Browse the repository at this point in the history
  36. doc: remove obsolete comment in isError() example

    One of the util.isError() examples states that a harmony flag
    is required. As of v6.0.0, this is no longer true. This commit
    removes the out of date reference.
    
    Refs: #5414
    PR-URL: #6486
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    cjihrig authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    3e028a1 View commit details
    Browse the repository at this point in the history
  37. doc: fix sentence fragment in fs doc

    PR-URL: #6488
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
    Trott authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    e5ce53a View commit details
    Browse the repository at this point in the history
  38. test: add failing url parse tests as known_issue

    url resolve and parse do not currently adhere to the same url
    spec parsing rules that browsers use, which leads to some
    issues. This addition to test/known_issues creates a set of
    tests based on the w3c/whatwg test suite from:
    
    Refs: https://github.com/w3c/web-platform-tests/tree/master/url
    
    PR-URL: #5885
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    jasnell authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    457d12a View commit details
    Browse the repository at this point in the history
  39. test: make addon testing part of make test

    Otherwise it's too easy to miss breaking changes to node.h and other
    public headers until the CI catches them.  `vcbuild test` tests addons
    so there is precedence.
    
    PR-URL: #6232
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    bnoordhuis authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    5fe5fa2 View commit details
    Browse the repository at this point in the history
  40. debugger: display array contents in repl

    This commit allows all array properties to be printed except for
    "length". Previously, this filter was applied by checking the
    type of each property. However, something changed in V8, and
    array elements started coming through as numeric strings, which
    stopped them from being displayed.
    
    Fixes: #6444
    PR-URL: #6448
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    cjihrig authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    2d503b1 View commit details
    Browse the repository at this point in the history
  41. test: refactor large event emitter tests

    This commit splits several large event emitter tests into smaller
    block scoped tests. This keeps the tests more isolated. This
    commit also replaces var with const, assert.equal() with
    assert.stictEqual(), and other small enhancements.
    
    PR-URL: #6446
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    7641f9a View commit details
    Browse the repository at this point in the history
  42. doc: ensure consistent grammar in node.1 file

    PR-URL: #6426
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    justshiv authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    7c30f15 View commit details
    Browse the repository at this point in the history
  43. tools: add -F flag for fixing lint issues

    Add `-F` flag to `jslint.js` which enables the automatic fixing of
    issues that are fixable.
    
    PR-URL: #6483
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Trott authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    08e0884 View commit details
    Browse the repository at this point in the history
  44. cluster: remove use of bind() in destroy()

    This commit replaces process.exit.bind() with an arrow function
    in Worker.prototype.destroy().
    
    PR-URL: #6502
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    yorkie authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    1330496 View commit details
    Browse the repository at this point in the history
  45. doc: add missing underscore for markdown italics

    A closing underscore was missing from the `poll` section of the event
    loop doc. Also emboldened a word for continuity and readability.
    
    PR-URL: #6529
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Kevin Donahue authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    d674493 View commit details
    Browse the repository at this point in the history
  46. util: fix inspecting of proxy objects

    In certain conditions, inspecting a Proxy object can lead to a
    max call stack error. Avoid that by detecting the Proxy object
    and outputting information about the Proxy object itself.
    
    Fixes: #6464
    PR-URL: #6465
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    jasnell authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    0bca959 View commit details
    Browse the repository at this point in the history
  47. doc: fix the lint of an example in cluster.md

    PR-URL: #6516
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    yorkie authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    9a29b50 View commit details
    Browse the repository at this point in the history
  48. doc: linkify remaining references to fs.Stats object

    One reference to the `fs.Stats object` is linkified, while two other
    similarly made references to the object are not linkified.
    Linking the remaining references makes sense due to similar context.
    
    PR-URL: #6485
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Kevin Donahue authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    4f728df View commit details
    Browse the repository at this point in the history
  49. doc: adds 'close' events to fs.ReadStream and fs.WriteStream

    Add 'close' event to doc/api/fs.md --> fs.ReadStream
    Add 'close' event to doc/api/fs.md --> fs.WriteStream
    Add 'close event to doc/api/stream.md --> stream.Writable
    
    From squashed history:
    Add 'close' event to stream.Writable per Issue #6484
    Add #### prefix to Event: 'close' and backticks to 'close'
    similar to stream.Readable event: 'close' section
    Add more specifics to 'close' events for fs.ReadStream
    and fs.WriteStream
    Fix/Changed 'close' event from 'fs.ReadStream' to 'fs.WriteStream'
    wrapped long lines at 80 chars, reworded
    per Issue #6484
    including the 'close' event as optional
    add 'close' event as optional in stream.Readable
    per issue #6484
    doc: Add 'close' events to fs.ReadStream, 80char nit
    
    Fixes: #6484
    PR-URL: #6499
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
    Jenna Vuong authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    33f24c8 View commit details
    Browse the repository at this point in the history
  50. util: truncate inspect array and typed array

    As an alternative to #5070,
    set the max length of Arrays/TypedArrays in util.inspect() to
    `100` and provide a `maxArrayLength` option to override.
    
    PR-URL: #6334
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    jasnell authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    91ab769 View commit details
    Browse the repository at this point in the history
  51. deps: backport IsValid changes from 4e8736d in V8

    V8 erroneously did null pointer checks on `this`.
    It can lead to a SIGSEGV crash if node is compiled with GCC 6.
    Backport relevant changes from [1] that fix this issue.
    
    [1]: https://codereview.chromium.org/1900423002
    
    Fixes: #6272
    PR-URL: #6544
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    targos authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    65b6574 View commit details
    Browse the repository at this point in the history
  52. deps: upgrade openssl sources to 1.0.2h

    This replaces all sources of openssl-1.0.2h.tar.gz into
    deps/openssl/openssl
    
    Fixes: #6458
    PR-URL: #6550
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Shigeki Ohtsu authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    e6ab3ec View commit details
    Browse the repository at this point in the history
  53. deps: copy all openssl header files to include dir

    All symlink files in `deps/openssl/openssl/include/openssl/`
    are removed and replaced with real header files to avoid
    issues on Windows. Two files of opensslconf.h in crypto and
    include dir are replaced to refer config/opensslconf.h.
    
    Fixes: #6458
    PR-URL: #6550
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Shigeki Ohtsu authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    3af28d3 View commit details
    Browse the repository at this point in the history
  54. deps: fix openssl assembly error on ia32 win32

    `x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and
    perhaps others) are requiring .686 .
    
    Fixes: #589
    PR-URL: #1389
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
    indutny authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    d159462 View commit details
    Browse the repository at this point in the history
  55. deps: fix asm build error of openssl in x86_win32

    See
    https://mta.openssl.org/pipermail/openssl-dev/2015-February/000651.html
    
    iojs needs to stop using masm and move to nasm or yasm on Win32.
    
    Fixes: #589
    PR-URL: #1389
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Shigeki Ohtsu authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    3fe6812 View commit details
    Browse the repository at this point in the history
  56. openssl: fix keypress requirement in apps on win32

    Reapply b910613 .
    
    Fixes: #589
    PR-URL: #1389
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Shigeki Ohtsu authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    534f03c View commit details
    Browse the repository at this point in the history
  57. deps: add -no_rand_screen to openssl s_client

    In openssl s_client on Windows, RAND_screen() is invoked to initialize
    random state but it takes several seconds in each connection.
    This added -no_rand_screen to openssl s_client on Windows to skip
    RAND_screen() and gets a better performance in the unit test of
    test-tls-server-verify.
    Do not enable this except to use in the unit test.
    
    Fixes: #1461
    PR-URL: #1836
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Shigeki Ohtsu authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    a5a2944 View commit details
    Browse the repository at this point in the history
  58. deps: update openssl asm and asm_obsolete files

    Regenerate asm files with Makefile and CC=gcc and ASM=gcc where
    gcc-4.8.4. Also asm files in asm_obsolete dir to support old compiler
    and assembler are regenerated without CC and ASM envs.
    
    Fixes: #6458
    PR-URL: #6550
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Shigeki Ohtsu authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    54f8600 View commit details
    Browse the repository at this point in the history
  59. test: fix alpn tests for openssl1.0.2h

    openssl/openssl@af2db04
    changed some ALPN behaviors. The tests when ALPN has no selection
    should be fixed because openssl was changed NPN callback to be invoked
    in this case.
    
    Fixes: #6458
    PR-URL: #6550
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Shigeki Ohtsu authored and Fishrock123 committed May 4, 2016
    Configuration menu
    Copy the full SHA
    65030c7 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2016

  1. 2016-05-05, Version 6.1.0 (Current)

    * assert: `deep{Strict}Equal()` now works correctly with circular
    references. (Rich Trott) #6432
    * debugger: Arrays are now formatted correctly in the debugger repl.
    (cjihrig) #6448
    * deps: Upgrade OpenSSL sources to 1.0.2h (Shigeki Ohtsu)
    #6550
    * net: Introduced a `Socket#connecting` property. (Fedor Indutny)
    #6404
      - Previously this information was only available as the undocumented,
    internal `_connecting` property.
    * process: Introduced `process.cpuUsage()`. (Patrick Mueller)
    #6157
    * stream: `Writable#setDefaultEncoding()` now returns `this`.
    (Alexander Makarenko) #5040
    * util: Two new additions to `util.inspect()`:
      - Added a `maxArrayLength` option to truncate the formatting of
    Arrays. (James M Snell) #6334
        - This is set to `100` by default.
      - Added a `showProxy` option for formatting proxy intercepting
    handlers. (James M Snell) #6465
        - Inspecting proxies is non-trivial and as such this is off by
    default.
    
    PR-URL: #6557
    Fishrock123 committed May 5, 2016
    Configuration menu
    Copy the full SHA
    cd7b76e View commit details
    Browse the repository at this point in the history
  2. Working on v6.1.1

    PR-URL: #6557
    Fishrock123 committed May 5, 2016
    Configuration menu
    Copy the full SHA
    8aa8f18 View commit details
    Browse the repository at this point in the history