assert: use util.inspect() to create error messages #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That would be my suggestion. I'm +1 on this patch. I think the biggest question is whether this is semver-major or minor. I think this is a minimal behavioral change for which a minor version bump is appropriate. |
Currently, JSON.stringify() is used to create error messages on failed assertions. This causes an error when stringifying objects with circular references. This commit switches out JSON.stringify() for util.inspect(), which can handle circular references.
|
I'm in favor of semver patch here: it's not new "behavior" – in the form of a new API method or parameter, and doesn't change the contract – trying to JSON.parse will still explode, just more often now :) I'm also +1 on this patch. |
|
I have updated the PR. Since the window is currently open for a minor version, I'll land this tomorrow if no one protests. |
cjihrig
added a commit
that referenced
this pull request
Jan 31, 2015
Currently, JSON.stringify() is used to create error messages on failed assertions. This causes an error when stringifying objects with circular references. This commit switches out JSON.stringify() for util.inspect(), which can handle circular references. PR-URL: #668 Reviewed-By: Julien Gilli <julien.gilli@joyent.com> Reviewed-By: Bert Belder <bertbelder@gmail.com> Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
|
Landed in 40e29dc |
This was referenced Mar 22, 2022
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
JSON.stringify()is used to create error messages on failed assertions. This causes an error when stringifying objects with circular references. This commit switches outJSON.stringify()forutil.inspect(), which can handle circular references.This is a port of nodejs/node-v0.x-archive#8734. The main question here is about semver labeling.
cc: @piscisaureus