Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable line ending normalization in git, not in the linter #7019

Closed
wants to merge 5 commits into from
Closed

Enable line ending normalization in git, not in the linter #7019

wants to merge 5 commits into from

Commits on Jun 8, 2016

  1. meta: enable git auto end-of-line normalization 

    Git should convert the line endings of text files to CRLF on Windows
and only LF on Unix. It should also convert line endings of text
files stored in the repository to only LF.
    @joaocgreis
    joaocgreis committed Jun 8, 2016
    Configuration menu
    Copy the full SHA
    a037243 View commit details
    Browse the repository at this point in the history

  2. tools: do not enforce a linebreak style in linter 

    Linebreak style should be enforced by git in a cross platform way,
and not by the linter.

Fixes: nodejs#6912
    @joaocgreis
    joaocgreis committed Jun 8, 2016
    Configuration menu
    Copy the full SHA
    bed497f View commit details
    Browse the repository at this point in the history

  3. fixup meta: exclude a v8 test 

    using text=auto this file is handled correctly by git, but with the
new configuration it is not. Better add an exception in both cases
just in case.
    @joaocgreis
    joaocgreis committed Jun 8, 2016
    Configuration menu
    Copy the full SHA
    be486b8 View commit details
    Browse the repository at this point in the history

  4. fixup tools: linebreak-style: 0

    @joaocgreis
    joaocgreis committed Jun 8, 2016
    Configuration menu
    Copy the full SHA
    86bd27a View commit details
    Browse the repository at this point in the history

  5. fixup meta: enable text only for selected extensions

    @joaocgreis
    joaocgreis committed Jun 8, 2016
    Configuration menu
    Copy the full SHA
    a4298de View commit details
    Browse the repository at this point in the history