Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: clean up ArrayBufferAllocator #7082

Merged
merged 4 commits into from
Jun 1, 2016
Merged

src: clean up ArrayBufferAllocator #7082

merged 4 commits into from
Jun 1, 2016

Commits on Jun 1, 2016

  1. src: move IsolateData out of Environment 

    A follow-up commit is going to make IsolateData creation explicit.
In order for that to work, it needs to move out of Environment.

PR-URL: nodejs#7082
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    @bnoordhuis
    bnoordhuis committed Jun 1, 2016
    Configuration menu
    Copy the full SHA
    0301ce9 View commit details
    Browse the repository at this point in the history

  2. src: make IsolateData creation explicit 

    Make it easier to reason about the lifetime and the ownership of the
IsolateData instance by making its creation explicit and by removing
reference counting logic.

The creator of the Environment is now responsible for passing in the
IsolateData instance and for keeping it alive as long as the Environment
is alive.

PR-URL: nodejs#7082
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    @bnoordhuis
    bnoordhuis committed Jun 1, 2016
    Configuration menu
    Copy the full SHA
    c3cd453 View commit details
    Browse the repository at this point in the history

  3. lib,src: drop dependency on v8::Private::ForApi() 

    Said function requires that a v8::Context has been entered first,
introducing a chicken-and-egg problem when creating the first context.

PR-URL: nodejs#7082
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    @bnoordhuis
    bnoordhuis committed Jun 1, 2016
    4 Configuration menu
    Copy the full SHA
    334ef4f View commit details
    Browse the repository at this point in the history

  4. lib,src: clean up ArrayBufferAllocator 

    Remove the direct dependency on node::Environment (which is per-context)
from node::ArrayBufferAllocator (which is per-isolate.)

Contexts that want to toggle the zero fill flag, now do so through a
field that is owned by ArrayBufferAllocator.  Better, still not great.

PR-URL: nodejs#7082
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    @bnoordhuis
    bnoordhuis committed Jun 1, 2016
    4 Configuration menu
    Copy the full SHA
    27e84dd View commit details
    Browse the repository at this point in the history