http: fix connection upgrade checks #8238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @nodejs/http |
|
CI is green except for an unrelated failure on AIX. |
|
LGTM |
mscdex
force-pushed
the
http-add-headers-guard
branch
from
fd38f3a
to
f216ecb
Compare
This commit fixes connection upgrade checks, specifically when headers are passed as an array instead of a plain object to http.request() Fixes: nodejs#8235 PR-URL: nodejs#8238 Reviewed-By: James M Snell <jasnell@gmail.com>
mscdex
force-pushed
the
http-add-headers-guard
branch
from
f216ecb
to
1050594
Compare
Closed
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Sep 8, 2016
This commit fixes connection upgrade checks, specifically when headers are passed as an array instead of a plain object to http.request() Fixes: nodejs#8235 PR-URL: nodejs#8238 Reviewed-By: James M Snell <jasnell@gmail.com>
|
@mscdex this does not land cleanly on v4.x, but we definitely should backport as I have confirmed it is broken on v4.x Would you be able to backport? |
|
ping @mscdex |
mscdex
added a commit
to mscdex/io.js
that referenced
this pull request
Nov 18, 2016
This commit fixes connection upgrade checks, specifically when headers are passed as an array instead of a plain object to http.request() Fixes: nodejs#8235 PR-URL: nodejs#8238 Reviewed-By: James M Snell <jasnell@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
This commit fixes connection upgrade checks, specifically when headers are passed as an array instead of a plain object to
http.request().Fixes: #8235